build_overrides/build.gni - Issue 2982863002: Remove deprecated macOS SDK overrides.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/build.gni

Issue 2982863002: Remove deprecated macOS SDK overrides. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.	1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

2 #	2 #

3 # Use of this source code is governed by a BSD-style license	3 # Use of this source code is governed by a BSD-style license

4 # that can be found in the LICENSE file in the root of the source	4 # that can be found in the LICENSE file in the root of the source

5 # tree. An additional intellectual property rights grant can be found	5 # tree. An additional intellectual property rights grant can be found

6 # in the file PATENTS. All contributing project authors may	6 # in the file PATENTS. All contributing project authors may

7 # be found in the AUTHORS file in the root of the source tree.	7 # be found in the AUTHORS file in the root of the source tree.

8	8

9 # Some WebRTC targets require a 10.11 min SDK but those targets are only

10 # used in non-Chromium builds.

11 mac_sdk_min_build_override = "10.11"
tommi 2017/07/14 21:22:33 the comment says that this is used for non-Chromiu the comment says that this is used for non-Chromium builds (if I'm understanding correctly). Are you removing this because of a problem in Chromium? If so, would it make more sense to set this conditionally? (i.e. only for non-Chromium builds)
12

13 # Some non-Chromium builds don't support building java targets.	9 # Some non-Chromium builds don't support building java targets.

14 enable_java_templates = true	10 enable_java_templates = true

15	11

16 # Some non-Chromium builds don't use Chromium's third_party/binutils.	12 # Some non-Chromium builds don't use Chromium's third_party/binutils.

17 linux_use_bundled_binutils_override = true	13 linux_use_bundled_binutils_override = true

18	14

19 # Variable that can be used to support multiple build scenarios, like having	15 # Variable that can be used to support multiple build scenarios, like having

20 # Chromium specific targets in a client project's GN file etc.	16 # Chromium specific targets in a client project's GN file etc.

21 build_with_chromium = false	17 build_with_chromium = false

22	18

(...skipping 12 matching lines...) Expand all Loading...
35 lint_suppressions_file = "//tools_webrtc/android/suppressions.xml"	31 lint_suppressions_file = "//tools_webrtc/android/suppressions.xml"

36	32

37 # For Chromium, Android 32-bit non-component, non-clang builds hit a 4GiB size	33 # For Chromium, Android 32-bit non-component, non-clang builds hit a 4GiB size

38 # limit, making them requiring symbol_level=2. WebRTC doesn't hit that problem	34 # limit, making them requiring symbol_level=2. WebRTC doesn't hit that problem

39 # so we just ignore that assert. See https://crbug.com/648948 for more info.	35 # so we just ignore that assert. See https://crbug.com/648948 for more info.

40 ignore_elf32_limitations = true	36 ignore_elf32_limitations = true

41	37

42 # Use system Xcode installation instead of the Chromium bundled Mac toolchain,	38 # Use system Xcode installation instead of the Chromium bundled Mac toolchain,

43 # since it contains only SDK 10.11, not 10.12 which WebRTC needs.	39 # since it contains only SDK 10.11, not 10.12 which WebRTC needs.

44 use_system_xcode = true	40 use_system_xcode = true

OLD	NEW