Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2979993003: Revert of iOS - Add iceRegatherIntervalRange. (Closed)

Created:
3 years, 5 months ago by magjed_webrtc
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of iOS - Add iceRegatherIntervalRange. (patchset #1 id:1 of https://codereview.webrtc.org/2976953002/ ) Reason for revert: Blocks reverting: https://chromium-review.googlesource.com/c/562505 Original issue's description: > iOS - Add iceRegatherIntervalRange. > > BUG=webrtc:7969 > > Review-Url: https://codereview.webrtc.org/2976953002 > Cr-Commit-Position: refs/heads/master@{#18997} > Committed: https://chromium.googlesource.com/external/webrtc/+/5e0ed36d7403886a99f22e05103279abf150b646 TBR=haysc@webrtc.org,steveanton@webrtc.org,tkchin@webrtc.org NOTRY=TRUE BUG=webrtc:7969 Review-Url: https://codereview.webrtc.org/2979993003 Cr-Commit-Position: refs/heads/master@{#19023} Committed: https://chromium.googlesource.com/external/webrtc/+/93adc3209b5ff10adaba54d5eab6b53bc2780685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -198 lines) Patch
M webrtc/sdk/BUILD.gn View 4 chunks +0 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCConfiguration.mm View 5 chunks +2 lines, -16 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCIntervalRange.mm View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCIntervalRange+Private.h View 1 chunk +0 lines, -27 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 2 chunks +0 lines, -8 lines 0 comments Download
D webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIntervalRange.h View 1 chunk +0 lines, -28 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm View 6 chunks +0 lines, -9 lines 0 comments Download
D webrtc/sdk/objc/Framework/UnitTests/RTCIntervalRangeTests.mm View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
magjed_webrtc
Created Revert of iOS - Add iceRegatherIntervalRange.
3 years, 5 months ago (2017-07-14 14:33:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979993003/1
3 years, 5 months ago (2017-07-14 14:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979993003/1
3 years, 5 months ago (2017-07-14 14:55:51 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 14:59:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/93adc3209b5ff10adaba54d5e...

Powered by Google App Engine
This is Rietveld 408576698