Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2976953002: iOS - Add iceRegatherIntervalRange. (Closed)

Created:
3 years, 5 months ago by tkchin_webrtc
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS - Add iceRegatherIntervalRange. BUG=webrtc:7969 Review-Url: https://codereview.webrtc.org/2976953002 Cr-Commit-Position: refs/heads/master@{#18997} Committed: https://chromium.googlesource.com/external/webrtc/+/5e0ed36d7403886a99f22e05103279abf150b646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -2 lines) Patch
M webrtc/sdk/BUILD.gn View 4 chunks +5 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCConfiguration.mm View 5 chunks +16 lines, -2 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCIntervalRange.mm View 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCIntervalRange+Private.h View 1 chunk +27 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 2 chunks +8 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Headers/WebRTC/RTCIntervalRange.h View 1 chunk +28 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/WebRTC.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm View 6 chunks +9 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/UnitTests/RTCIntervalRangeTests.mm View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
tkchin_webrtc
3 years, 5 months ago (2017-07-12 22:46:38 UTC) #3
Steve Anton
lgtm lgtm
3 years, 5 months ago (2017-07-12 23:11:00 UTC) #4
Chuck
lgtm
3 years, 5 months ago (2017-07-12 23:19:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2976953002/1
3 years, 5 months ago (2017-07-12 23:59:13 UTC) #7
tkchin_webrtc
+kjellander for BUILD.gn
3 years, 5 months ago (2017-07-13 00:04:37 UTC) #9
tkchin_webrtc
nevermind, kjellander@ is OOO magjed@ can you approve BUILD.gn?
3 years, 5 months ago (2017-07-13 00:05:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19220)
3 years, 5 months ago (2017-07-13 00:05:44 UTC) #13
magjed_webrtc
lgtm
3 years, 5 months ago (2017-07-13 09:14:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2976953002/1
3 years, 5 months ago (2017-07-13 09:14:50 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/5e0ed36d7403886a99f22e05103279abf150b646
3 years, 5 months ago (2017-07-13 09:17:52 UTC) #19
magjed_webrtc
3 years, 5 months ago (2017-07-14 14:33:03 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2979993003/ by magjed@webrtc.org.

The reason for reverting is: Blocks reverting:
https://chromium-review.googlesource.com/c/562505.

Powered by Google App Engine
This is Rietveld 408576698