Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2979803002: Reland of Make "set_ignore_non_default_routes" actually use its argument. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Make "set_ignore_non_default_routes" actually use its argument. (patchset #1 id:1 of https://codereview.webrtc.org/2974193002/ ) Reason for revert: Wasn't actually the source of the memcheck issue, so relanding. Original issue's description: > Revert of Make "set_ignore_non_default_routes" actually use its argument. (patchset #1 id:1 of https://codereview.webrtc.org/2974873002/ ) > > Reason for revert: > Breaks Linux memcheck bot. > https://bugs.chromium.org/p/webrtc/issues/detail?id=7973 > > Original issue's description: > > Make "set_ignore_non_default_routes" actually use its argument. > > > > It takes a bool argument, but unconditionally sets the flag to "true". > > Since no comment is left to offer an explanation, I'm assuming this was > > an accident. > > > > BUG=webrtc:7716 > > TBR=pthatcher@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2974873002 > > Cr-Commit-Position: refs/heads/master@{#18959} > > Committed: https://chromium.googlesource.com/external/webrtc/+/05314c3252ec4eea20c91c41d82e3eb06c0a91db > > TBR=pthatcher@webrtc.org,pthatcher@google.com,deadbeef@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7716 > > Review-Url: https://codereview.webrtc.org/2974193002 > Cr-Commit-Position: refs/heads/master@{#18964} > Committed: https://chromium.googlesource.com/external/webrtc/+/1e50748d47357b61fdd8e25375f7dfd510832791 TBR=pthatcher@webrtc.org,pthatcher@google.com,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7716 Review-Url: https://codereview.webrtc.org/2979803002 Cr-Commit-Position: refs/heads/master@{#18982} Committed: https://chromium.googlesource.com/external/webrtc/+/be7e9c6047185afea06f6e324ee88dc7cc1f9b59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/rtc_base/network.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Reland of Make "set_ignore_non_default_routes" actually use its argument.
3 years, 5 months ago (2017-07-12 03:07:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979803002/1
3 years, 5 months ago (2017-07-12 03:07:34 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 03:07:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/be7e9c6047185afea06f6e324...

Powered by Google App Engine
This is Rietveld 408576698