Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2974873002: Make "set_ignore_non_default_routes" actually use its argument. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
Reviewers:
pthatcher, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make "set_ignore_non_default_routes" actually use its argument. It takes a bool argument, but unconditionally sets the flag to "true". Since no comment is left to offer an explanation, I'm assuming this was an accident. BUG=webrtc:7716 TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2974873002 Cr-Commit-Position: refs/heads/master@{#18959} Committed: https://chromium.googlesource.com/external/webrtc/+/05314c3252ec4eea20c91c41d82e3eb06c0a91db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/rtc_base/network.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
Another trivial bug fix I'm going to land TBR
3 years, 5 months ago (2017-07-11 02:28:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974873002/1
3 years, 5 months ago (2017-07-11 02:28:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/05314c3252ec4eea20c91c41d82e3eb06c0a91db
3 years, 5 months ago (2017-07-11 02:52:34 UTC) #6
pthatcher
lgtm
3 years, 5 months ago (2017-07-11 05:26:31 UTC) #8
sprang_webrtc
3 years, 5 months ago (2017-07-11 10:45:43 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2974193002/ by sprang@webrtc.org.

The reason for reverting is: Breaks Linux memcheck bot.
https://bugs.chromium.org/p/webrtc/issues/detail?id=7973.

Powered by Google App Engine
This is Rietveld 408576698