Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2979733002: Revert of Delete SignalThread class. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete SignalThread class. (patchset #20 id:380001 of https://codereview.webrtc.org/2915253002/ ) Reason for revert: Seems to be causing new crashes, possibly because of changes to the "Destroy(false)" behavior. Will re-land after investigating these crashes more and addressing the root cause. Original issue's description: > Delete SignalThread class. > > Rewrite AsyncResolver to use PlatformThread directly, not > SignalThread, and update includes of peerconnection client to not > depend on signalthread.h. > > BUG=webrtc:6424, webrtc:7723 > > Review-Url: https://codereview.webrtc.org/2915253002 > Cr-Commit-Position: refs/heads/master@{#18833} > Committed: https://chromium.googlesource.com/external/webrtc/+/bc8feda1db02b2a9b501e4aa43926ca7e861b638 TBR=tommi@webrtc.org,kwiberg@webrtc.org,nisse@webrtc.org NOPRESUBMIT=true NOTRY=true BUG=webrtc:6424, webrtc:7723 Review-Url: https://codereview.webrtc.org/2979733002 Cr-Commit-Position: refs/heads/master@{#18980} Committed: https://chromium.googlesource.com/external/webrtc/+/8290ddfbce0ecd3d178c1bc280007dd796819538

Patch Set 1 #

Patch Set 2 : Fix merge conflicts. #

Patch Set 3 : Update peer_connection_client #

Patch Set 4 : Change EXPECT_STATE macro to a function, since it was broken by recent gunit.h change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -168 lines) Patch
A webrtc/base/signalthread.h View 1 chunk +19 lines, -0 lines 0 comments Download
M webrtc/examples/peerconnection/client/peer_connection_client.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/peer_connection_client.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/rtc_base/BUILD.gn View 1 3 chunks +3 lines, -1 line 0 comments Download
M webrtc/rtc_base/messagequeue.h View 1 2 3 chunks +0 lines, -33 lines 0 comments Download
M webrtc/rtc_base/messagequeue.cc View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M webrtc/rtc_base/nethelpers.h View 1 2 chunks +11 lines, -35 lines 0 comments Download
M webrtc/rtc_base/nethelpers.cc View 1 3 chunks +13 lines, -79 lines 0 comments Download
A webrtc/rtc_base/signalthread.h View 1 chunk +161 lines, -0 lines 0 comments Download
A webrtc/rtc_base/signalthread.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/rtc_base/signalthread_unittest.cc View 1 2 3 1 chunk +210 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Taylor Brandstetter
Created Revert of Delete SignalThread class.
3 years, 5 months ago (2017-07-11 18:01:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979733002/1
3 years, 5 months ago (2017-07-11 18:01:52 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/5976) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 5 months ago (2017-07-11 18:03:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979733002/250001
3 years, 5 months ago (2017-07-11 19:35:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_rel/builds/2698)
3 years, 5 months ago (2017-07-11 19:38:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979733002/270001
3 years, 5 months ago (2017-07-11 21:32:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/5984) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 5 months ago (2017-07-11 21:36:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979733002/290001
3 years, 5 months ago (2017-07-11 22:40:00 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19171)
3 years, 5 months ago (2017-07-11 22:45:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2979733002/290001
3 years, 5 months ago (2017-07-11 23:55:58 UTC) #20
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 23:56:14 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:290001) as
https://chromium.googlesource.com/external/webrtc/+/8290ddfbce0ecd3d178c1bc28...

Powered by Google App Engine
This is Rietveld 408576698