Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2974893002: Reland of refactor timing frame logic to work with encoders with internal sources (Closed)

Created:
3 years, 5 months ago by ilnik
Modified:
3 years, 5 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Refactor timing frame logic to work with encoders with internal sources (patchset #1 id:1 of https://codereview.webrtc.org/2980533002/ ) BUG=webrtc:7594, webrtc:7893 Review-Url: https://codereview.webrtc.org/2974893002 Cr-Commit-Position: refs/heads/master@{#18974} Committed: https://chromium.googlesource.com/external/webrtc/+/29d0840b5c79df20fab70e5552f1bceb43a8bddb

Patch Set 1 : Original reverted patch #

Patch Set 2 : Add debug output #

Patch Set 3 : Fix debug output CE for win #

Patch Set 4 : Disable timing frames for encoders with internal sources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M webrtc/modules/video_coding/generic_encoder.cc View 1 2 3 3 chunks +45 lines, -42 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
ilnik
Created Reland of actor timing frame logic to work with encoders with internal sources
3 years, 5 months ago (2017-07-11 07:55:33 UTC) #1
ilnik
Please see only on a diff between the last and the first patchsets. Now, timing ...
3 years, 5 months ago (2017-07-11 13:51:16 UTC) #6
sprang_webrtc
lgtm Also, please don't use TBR unless the reland change is trivial (eg rebase).
3 years, 5 months ago (2017-07-11 14:27:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974893002/80001
3 years, 5 months ago (2017-07-11 15:04:30 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 15:08:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/29d0840b5c79df20fab70e555...

Powered by Google App Engine
This is Rietveld 408576698