Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2980533002: Revert of Refactor timing frame logic to work with encoders with internal sources (Closed)

Created:
3 years, 5 months ago by ilnik
Modified:
3 years, 5 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactor timing frame logic to work with encoders with internal sources (patchset #2 id:20001 of https://codereview.webrtc.org/2968153002/ ) Reason for revert: Failing chromoting tests Original issue's description: > Refactor timing frame logic to work with encoders with internal sources > > BUG=webrtc:7594, webrtc:7893 > > Review-Url: https://codereview.webrtc.org/2968153002 > Cr-Commit-Position: refs/heads/master@{#18955} > Committed: https://chromium.googlesource.com/external/webrtc/+/a7a4535a35e2fccfab06c79d8704c1ca92970a6e TBR=sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7594, webrtc:7893 Review-Url: https://codereview.webrtc.org/2980533002 Cr-Commit-Position: refs/heads/master@{#18957} Committed: https://chromium.googlesource.com/external/webrtc/+/0b1e2f327912806a3f070ce72c19dff01b130de2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M webrtc/modules/video_coding/generic_encoder.cc View 3 chunks +40 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ilnik
Created Revert of Refactor timing frame logic to work with encoders with internal sources
3 years, 5 months ago (2017-07-10 19:25:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2980533002/1
3 years, 5 months ago (2017-07-10 19:25:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0b1e2f327912806a3f070ce72c19dff01b130de2
3 years, 5 months ago (2017-07-10 19:25:37 UTC) #6
ilnik
3 years, 5 months ago (2017-07-11 07:55:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2974893002/ by ilnik@webrtc.org.

The reason for reverting is: Reland with fixes..

Powered by Google App Engine
This is Rietveld 408576698