Protected streams report RTP messages directly to the FlexFec streams

webrtc/call/flexfec_receive_stream_impl.h

Index: webrtc/call/flexfec_receive_stream_impl.h
diff --git a/webrtc/call/flexfec_receive_stream_impl.h b/webrtc/call/flexfec_receive_stream_impl.h
index 6a4eeae3e317e7f52cd1fdae5eec2bf3802a0bdf..681fc7f93417916b77382dbd302680e6451fb8d7 100644
--- a/webrtc/call/flexfec_receive_stream_impl.h
+++ b/webrtc/call/flexfec_receive_stream_impl.h
@@ -15,7 +15,6 @@
 
 #include "webrtc/base/criticalsection.h"
 #include "webrtc/call/flexfec_receive_stream.h"
-#include "webrtc/call/rtp_packet_sink_interface.h"
 
 namespace webrtc {
 
@@ -29,8 +28,7 @@ class RtpRtcp;
 class RtpStreamReceiverControllerInterface;
 class RtpStreamReceiverInterface;
 
-class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
-                                 public RtpPacketSinkInterface {
+class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
  public:
   FlexfecReceiveStreamImpl(
       RtpStreamReceiverControllerInterface* receiver_controller,
@@ -53,6 +51,8 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
  private:
   // Config.
   const Config config_;
+  // TODO(eladalon): This critical section, which only protects crit_, is odd.
+  // We should probably just use an atomic-bool.

[danilchap, 2017/07/19 12:07:25]

is this TODO somehow related to the CL topic?

[eladalon, 2017/07/21 14:42:08]

1. Looking at it again, I see I have mis-worded; the critical section only
protects started_.
2. Not really related to the CL topic, which is why I'm just keeping it as a
TODO, rather than fix. Or do you suggest filing a bug instead of adding the
TODO?

[danilchap, 2017/07/24 09:03:45]

this is issue looks too small to me to deserve an own bug.
Just create a separate CL and move discussion there.

Keeping it in this CL is a bit distracting. (There are lots of odd dependencies
in the codebase, so reading this TODO by default I assume it is one of those and
start searching for connection)

[eladalon, 2017/07/24 13:15:48]

Created https://codereview.webrtc.org/2991533002/

   bool started_ GUARDED_BY(crit_);
   rtc::CriticalSection crit_;