Protected streams report RTP messages directly to the FlexFec streams

webrtc/call/flexfec_receive_stream_impl.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_IMPL_H_
 #define WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_IMPL_H_
 
 #include <memory>
 
 #include "webrtc/base/criticalsection.h"
 #include "webrtc/call/flexfec_receive_stream.h"
-#include "webrtc/call/rtp_packet_sink_interface.h"
 
 namespace webrtc {
 
 class FlexfecReceiver;
 class ProcessThread;
 class ReceiveStatistics;
 class RecoveredPacketReceiver;
 class RtcpRttStats;
 class RtpPacketReceived;
 class RtpRtcp;
 class RtpStreamReceiverControllerInterface;
 class RtpStreamReceiverInterface;
 
-class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
-                                 public RtpPacketSinkInterface {
+class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
  public:
   FlexfecReceiveStreamImpl(
       RtpStreamReceiverControllerInterface* receiver_controller,
       const Config& config,
       RecoveredPacketReceiver* recovered_packet_receiver,
       RtcpRttStats* rtt_stats,
       ProcessThread* process_thread);
   ~FlexfecReceiveStreamImpl() override;
 
   // RtpPacketSinkInterface.
   void OnRtpPacket(const RtpPacketReceived& packet) override;
 
   // Implements FlexfecReceiveStream.
   void Start() override;
   void Stop() override;
   Stats GetStats() const override;
 
   const Config& GetConfig() const override;
 
  private:
   // Config.
   const Config config_;
+  // TODO(eladalon): This critical section, which only protects crit_, is odd.
+  // We should probably just use an atomic-bool.

[danilchap, 2017/07/19 12:07:25]

is this TODO somehow related to the CL topic?

[eladalon, 2017/07/21 14:42:08]

1. Looking at it again, I see I have mis-worded; the critical section only
protects started_.
2. Not really related to the CL topic, which is why I'm just keeping it as a
TODO, rather than fix. Or do you suggest filing a bug instead of adding the
TODO?

[danilchap, 2017/07/24 09:03:45]

this is issue looks too small to me to deserve an own bug.
Just create a separate CL and move discussion there.

Keeping it in this CL is a bit distracting. (There are lots of odd dependencies
in the codebase, so reading this TODO by default I assume it is one of those and
start searching for connection)

[eladalon, 2017/07/24 13:15:48]

Created https://codereview.webrtc.org/2991533002/

   bool started_ GUARDED_BY(crit_);
   rtc::CriticalSection crit_;
 
   // Erasure code interfacing.
   const std::unique_ptr<FlexfecReceiver> receiver_;
 
   // RTCP reporting.
   const std::unique_ptr<ReceiveStatistics> rtp_receive_statistics_;
   const std::unique_ptr<RtpRtcp> rtp_rtcp_;
   ProcessThread* process_thread_;
 
   std::unique_ptr<RtpStreamReceiverInterface> rtp_stream_receiver_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_CALL_FLEXFEC_RECEIVE_STREAM_IMPL_H_