Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2974093002: Fix presubmit check for webrtc/base. (Closed)

Created:
3 years, 5 months ago by ehmaldonado_webrtc
Modified:
3 years, 5 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix presubmit check for webrtc/base. Show a warning only when there's something to warn about. TBR=kjellander@webrtc.org NOTRY=True BUG=webrtc:7634 Review-Url: https://codereview.webrtc.org/2974093002 Cr-Commit-Position: refs/heads/master@{#18952} Committed: https://chromium.googlesource.com/external/webrtc/+/fe53355dcbc66b1fcb5c4f567d77bb173eae4ddb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ehmaldonado_webrtc
3 years, 5 months ago (2017-07-10 13:59:29 UTC) #3
mbonadei
On 2017/07/10 13:59:29, ehmaldonado_webrtc wrote: lgtm. Sorry for not spotting this in the previous review.
3 years, 5 months ago (2017-07-10 14:00:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974093002/1
3 years, 5 months ago (2017-07-10 14:01:00 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 14:04:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fe53355dcbc66b1fcb5c4f567...

Powered by Google App Engine
This is Rietveld 408576698