Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: PRESUBMIT.py

Issue 2974093002: Fix presubmit check for webrtc/base. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index bcdf42713cb45733018d4893020d25a83e009ce6..ca6a70a19eb3f42a516326adbf7d2a52c979cd23 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -522,10 +522,12 @@ def _CheckNoChangesToWebRTCBase(input_api, output_api):
if 'webrtc/base' in line:
problems.append(' %s: %s' % (f.LocalPath(), line_num))
- return [output_api.PresubmitPromptWarning(
- 'webrtc/base is being moved to webrtc/rtc_base (See '
- 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
- 'following files:\n' + '\n'.join(problems))]
+ if problems:
+ return [output_api.PresubmitPromptWarning(
+ 'webrtc/base is being moved to webrtc/rtc_base (See '
+ 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
+ 'following files:\n' + '\n'.join(problems))]
+ return []
def _CommonChecks(input_api, output_api):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698