Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2973613002: Moving asm code out of isac_fix_c sources list (Closed)

Created:
3 years, 5 months ago by mbonadei
Modified:
3 years, 5 months ago
Reviewers:
ehmaldonado_webrtc
CC:
peah-webrtc, tlegrand-webrtc, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving asm code out of isac_fix_c sources list BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2973613002 Cr-Commit-Position: refs/heads/master@{#18911} Committed: https://chromium.googlesource.com/external/webrtc/+/5c0d703382d554accb681efcf6d154905cc1a7c1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Making suffix consistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mbonadei
3 years, 5 months ago (2017-07-05 15:26:55 UTC) #2
ehmaldonado_webrtc
lgtm I'd try to keep the suffixes consistent, but it's not a big deal :) ...
3 years, 5 months ago (2017-07-05 15:31:19 UTC) #3
mbonadei
https://codereview.webrtc.org/2973613002/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2973613002/diff/1/webrtc/modules/audio_coding/BUILD.gn#newcode637 webrtc/modules/audio_coding/BUILD.gn:637: rtc_source_set("isac_fix_c_asm") { On 2017/07/05 15:31:18, ehmaldonado_webrtc wrote: > Why ...
3 years, 5 months ago (2017-07-06 09:45:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2973613002/20001
3 years, 5 months ago (2017-07-06 09:51:53 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 10:49:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/5c0d703382d554accb681efcf...

Powered by Google App Engine
This is Rietveld 408576698