Moving asm code out of isac_fix_c sources list

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../webrtc.gni")
 import("audio_coding.gni")
@@ skipping 616 matching lines @@
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
   sources = [
     "codecs/isac/fix/source/codec.h",
     "codecs/isac/fix/source/fft.c",
     "codecs/isac/fix/source/fft.h",
     "codecs/isac/fix/source/settings.h",
   ]
   public_configs = [ ":isac_fix_config" ]
 }
 
+rtc_source_set("isac_fix_c_asm") {

[ehmaldonado_webrtc, 2017/07/05 15:31:18]

Why is the suffix _asm here, and _arm_asm in
https://codereview.webrtc.org/2966173002/diff/1/webrtc/common_audio/BUILD.gn

[mbonadei, 2017/07/06 09:45:59]

Thanks for spotting this. I changed this to _arm_asm.

+  sources = []
+  if (current_cpu == "arm" && arm_version >= 7) {
+    sources += [
+      "codecs/isac/fix/source/lattice_armv7.S",
+      "codecs/isac/fix/source/pitch_filter_armv6.S",
+    ]
+  }
+}
+
 rtc_source_set("isac_fix_c") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
   sources = [
     "codecs/isac/fix/include/audio_decoder_isacfix.h",
     "codecs/isac/fix/include/audio_encoder_isacfix.h",
     "codecs/isac/fix/include/isacfix.h",
     "codecs/isac/fix/source/arith_routines.c",
     "codecs/isac/fix/source/arith_routines_hist.c",
     "codecs/isac/fix/source/arith_routines_logist.c",
     "codecs/isac/fix/source/arith_routins.h",
@@ skipping 48 matching lines @@
 
   public_deps = [
     ":isac_fix_common",
   ]
 
   if (rtc_build_with_neon) {
     deps += [ ":isac_neon" ]
   }
 
   if (current_cpu == "arm" && arm_version >= 7) {
-    sources += [
-      "codecs/isac/fix/source/lattice_armv7.S",
-      "codecs/isac/fix/source/pitch_filter_armv6.S",
-    ]
     sources -= [
       "codecs/isac/fix/source/lattice_c.c",
       "codecs/isac/fix/source/pitch_filter_c.c",
     ]
+    deps += [ ":isac_fix_c_asm" ]
   }
 
   if (current_cpu == "mipsel") {
     sources += [
       "codecs/isac/fix/source/entropy_coding_mips.c",
       "codecs/isac/fix/source/filters_mips.c",
       "codecs/isac/fix/source/lattice_mips.c",
       "codecs/isac/fix/source/pitch_estimator_mips.c",
       "codecs/isac/fix/source/transform_mips.c",
     ]
@@ skipping 1510 matching lines @@
 # webrtc/api/audio_codecs:builtin_audio_decoder_factory instead.
 # TODO(ossu): Remove this.
 rtc_source_set("builtin_audio_encoder_factory") {
   sources = [
     "codecs/builtin_audio_encoder_factory.h",
   ]
   deps = [
     "../../api/audio_codecs:builtin_audio_encoder_factory",
   ]
 }