Add presubmit check to prevent further changes to webrtc/base.

Add presubmit check to prevent further changes to webrtc/base.

R=mbonadei@webrtc.org
TBR=kjellander@webrtc.org
NOTRY=True
BUG=webrtc:7634
Review-Url: https://codereview.webrtc.org/2972363002
Cr-Commit-Position: refs/heads/master@{#18951}
Committed: https://chromium.googlesource.com/external/webrtc/+/ea0e08400cbb25cdf257fcfce657aa319b944688

[ehmaldonado_webrtc, 2017-07-10 13:21:45]

Description was changed from

==========
Add presubmit check to prevent further changes to webrtc/base.

BUG=webrtc:7634
==========

to

==========
Add presubmit check to prevent further changes to webrtc/base.

R=mbonadei@webrtc.org
TBR=kjellander@webrtc.org
BUG=webrtc:7634
==========

[ehmaldonado_webrtc, 2017-07-10 13:21:45]

ehmaldonado@webrtc.org changed reviewers:
+ mbonadei@webrtc.org

[mbonadei, 2017-07-10 13:33:22]

https://codereview.webrtc.org/2972363002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2972363002/diff/1/PRESUBMIT.py#newcode519
PRESUBMIT.py:519: problems.append('    ' + f.LocalPath())
I think we should add continue if we enter this branch and avoid to scan the
file for webrtc/base in changed contents.

[ehmaldonado_webrtc, 2017-07-10 13:35:19]

On 2017/07/10 13:33:22, mbonadei wrote:
> https://codereview.webrtc.org/2972363002/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.webrtc.org/2972363002/diff/1/PRESUBMIT.py#newcode519
> PRESUBMIT.py:519: problems.append('    ' + f.LocalPath())
> I think we should add continue if we enter this branch and avoid to scan the
> file for webrtc/base in changed contents.

Right. Done.

[mbonadei, 2017-07-10 13:39:47]

On 2017/07/10 13:35:19, ehmaldonado_webrtc wrote:
> On 2017/07/10 13:33:22, mbonadei wrote:
> > https://codereview.webrtc.org/2972363002/diff/1/PRESUBMIT.py
> > File PRESUBMIT.py (right):
> > 
> > https://codereview.webrtc.org/2972363002/diff/1/PRESUBMIT.py#newcode519
> > PRESUBMIT.py:519: problems.append('    ' + f.LocalPath())
> > I think we should add continue if we enter this branch and avoid to scan the
> > file for webrtc/base in changed contents.
> 
> Right. Done.

lgtm.

[ehmaldonado_webrtc, 2017-07-10 13:41:03]

Description was changed from

==========
Add presubmit check to prevent further changes to webrtc/base.

R=mbonadei@webrtc.org
TBR=kjellander@webrtc.org
BUG=webrtc:7634
==========

to

==========
Add presubmit check to prevent further changes to webrtc/base.

R=mbonadei@webrtc.org
TBR=kjellander@webrtc.org
NOTRY=True
BUG=webrtc:7634
==========

[ehmaldonado_webrtc, 2017-07-10 13:41:08]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-07-10 13:41:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-10 13:44:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499694068923760,
"parent_rev": "78460a712af9aa573aa91f9f4e3dd288bc9df7b3", "commit_rev":
"ea0e08400cbb25cdf257fcfce657aa319b944688"}

[commit-bot: I haz the power, 2017-07-10 13:44:14]

Description was changed from

==========
Add presubmit check to prevent further changes to webrtc/base.

R=mbonadei@webrtc.org
TBR=kjellander@webrtc.org
NOTRY=True
BUG=webrtc:7634
==========

to

==========
Add presubmit check to prevent further changes to webrtc/base.

R=mbonadei@webrtc.org
TBR=kjellander@webrtc.org
NOTRY=True
BUG=webrtc:7634

Review-Url: https://codereview.webrtc.org/2972363002
Cr-Commit-Position: refs/heads/master@{#18951}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ea0e08400cbb25cdf257fcfce...
==========

[commit-bot: I haz the power, 2017-07-10 13:44:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ea0e08400cbb25cdf257fcfce...