Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: PRESUBMIT.py

Issue 2972363002: Add presubmit check to prevent further changes to webrtc/base. (Closed)
Patch Set: Address comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3cc90cc0f916522ac402f604fad27c63d4c61a69..bcdf42713cb45733018d4893020d25a83e009ce6 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -510,6 +510,24 @@ def _CheckUsageOfGoogleProtobufNamespace(input_api, output_api):
return []
+def _CheckNoChangesToWebRTCBase(input_api, output_api):
+ """Checks that no changes refer to webrtc/base."""
+ problems = []
+
+ for f in input_api.AffectedFiles():
+ if os.path.join('webrtc', 'base') in f.LocalPath():
+ problems.append(' ' + f.LocalPath())
+ continue
+ for line_num, line in f.ChangedContents():
+ if 'webrtc/base' in line:
+ problems.append(' %s: %s' % (f.LocalPath(), line_num))
+
+ return [output_api.PresubmitPromptWarning(
+ 'webrtc/base is being moved to webrtc/rtc_base (See '
+ 'bugs.webrtc.org/7634). Please refer to webrtc/rtc_base instead in the '
+ 'following files:\n' + '\n'.join(problems))]
+
+
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
@@ -578,6 +596,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckUsageOfGoogleProtobufNamespace(input_api, output_api))
results.extend(_CheckOrphanHeaders(input_api, output_api))
results.extend(_CheckNewLineAtTheEndOfProtoFiles(input_api, output_api))
+ results.extend(_CheckNoChangesToWebRTCBase(input_api, output_api))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698