External APM usage downstream dependency support cleanup

External APM usage downstream dependency support cleanup

This CL removes code that supported the now removed 
downstream dependencies in the support for using an 
external audio processing module.

BUG=webrtc:7939
Review-Url: https://codereview.webrtc.org/2969213002
Cr-Commit-Position: refs/heads/master@{#18929}
Committed: https://chromium.googlesource.com/external/webrtc/+/e67bedbac3f9a472f9b08e613867f4ba23c4aa5c

[peah-webrtc, 2017-07-05 09:44:19]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 09:44:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-05 09:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 09:49:57]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18910)

[peah-webrtc, 2017-07-05 11:29:38]

Description was changed from

==========
Cleanup of CL for APM insertion after removal of downstream dependencies


Cleanup of CL for APM insertion after removal of downstream dependencies

BUG=
==========

to

==========
Cleanup of CL for APM insertion after removal of downstream dependencies


Cleanup of CL for APM insertion after removal of downstream dependencies

BUG=
==========

[peah-webrtc, 2017-07-05 11:29:39]

peah@webrtc.org changed reviewers:
+ ossu@webrtc.org

[peah-webrtc, 2017-07-05 11:30:20]

peah@webrtc.org changed reviewers:
+ perkj@webrtc.org

[peah-webrtc, 2017-07-05 11:31:04]

peah@webrtc.org changed reviewers:
+ henrika@webrtc.org

[peah-webrtc, 2017-07-05 11:39:58]

Description was changed from

==========
Cleanup of CL for APM insertion after removal of downstream dependencies


Cleanup of CL for APM insertion after removal of downstream dependencies

BUG=
==========

to

==========
External APM usage downstream dependency support cleanup

This CL removes code that supported the now removed 
downstream dependencies in the support for using an 
external audio processing module.

BUG=webrtc:7939
==========

[peah-webrtc, 2017-07-05 11:40:40]

Hi,
Could you please take a look at this CL?

[henrika_webrtc, 2017-07-05 11:45:14]

lgtm

[ossu, 2017-07-05 16:16:46]

lgtm % a naming nit

https://codereview.webrtc.org/2969213002/diff/1/webrtc/voice_engine/voe_base_...
File webrtc/voice_engine/voe_base_impl.cc (right):

https://codereview.webrtc.org/2969213002/diff/1/webrtc/voice_engine/voe_base_...
webrtc/voice_engine/voe_base_impl.cc:228: AudioProcessing* external_apm,
Is it really necessary to call this one the external APM if there's no longer an
internal APM that could be used? Makes it sound a bit like it's still optional.

[peah-webrtc, 2017-07-06 07:47:32]

https://codereview.webrtc.org/2969213002/diff/1/webrtc/voice_engine/voe_base_...
File webrtc/voice_engine/voe_base_impl.cc (right):

https://codereview.webrtc.org/2969213002/diff/1/webrtc/voice_engine/voe_base_...
webrtc/voice_engine/voe_base_impl.cc:228: AudioProcessing* external_apm,
On 2017/07/05 16:16:46, ossu wrote:
> Is it really necessary to call this one the external APM if there's no longer
an
> internal APM that could be used? Makes it sound a bit like it's still
optional.

Good point!
I changed that to the name audio_processing, which is the name which we try to
use throughout the code whenever possible.

Done.

[perkj_webrtc, 2017-07-07 10:58:56]

lgtm

[perkj_webrtc, 2017-07-07 10:58:56]

lgtm

lgtm

[peah-webrtc, 2017-07-07 10:59:53]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-07-07 10:59:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ossu@webrtc.org,
henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2969213002/#ps20001 (title:
"Changes in response to reviewer commments")

[commit-bot: I haz the power, 2017-07-07 10:59:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-07 11:25:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499425193186720,
"parent_rev": "a0349c138db62c52435be84b6c837f5f4758e264", "commit_rev":
"e67bedbac3f9a472f9b08e613867f4ba23c4aa5c"}

[commit-bot: I haz the power, 2017-07-07 11:25:16]

Description was changed from

==========
External APM usage downstream dependency support cleanup

This CL removes code that supported the now removed 
downstream dependencies in the support for using an 
external audio processing module.

BUG=webrtc:7939
==========

to

==========
External APM usage downstream dependency support cleanup

This CL removes code that supported the now removed 
downstream dependencies in the support for using an 
external audio processing module.

BUG=webrtc:7939

Review-Url: https://codereview.webrtc.org/2969213002
Cr-Commit-Position: refs/heads/master@{#18929}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e67bedbac3f9a472f9b08e613...
==========

[commit-bot: I haz the power, 2017-07-07 11:25:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/e67bedbac3f9a472f9b08e613...