Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: webrtc/voice_engine/voe_base_impl.h

Issue 2969213002: External APM usage downstream dependency support cleanup (Closed)
Patch Set: Changes in response to reviewer commments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/voice_engine/include/voe_base.h ('k') | webrtc/voice_engine/voe_base_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 class VoEBaseImpl : public VoEBase, 24 class VoEBaseImpl : public VoEBase,
25 public AudioTransport, 25 public AudioTransport,
26 public AudioDeviceObserver { 26 public AudioDeviceObserver {
27 public: 27 public:
28 int RegisterVoiceEngineObserver(VoiceEngineObserver& observer) override; 28 int RegisterVoiceEngineObserver(VoiceEngineObserver& observer) override;
29 int DeRegisterVoiceEngineObserver() override; 29 int DeRegisterVoiceEngineObserver() override;
30 30
31 int Init( 31 int Init(
32 AudioDeviceModule* external_adm, 32 AudioDeviceModule* external_adm,
33 AudioProcessing* external_apm, 33 AudioProcessing* audio_processing,
34 const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) override; 34 const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) override;
35 AudioProcessing* audio_processing() override {
36 // TODO(peah): Remove this when downstream dependencies have properly been
37 // resolved.
38 RTC_DCHECK(audio_processing_);
39 return audio_processing_.get();
40 }
41 AudioDeviceModule* audio_device_module() override { 35 AudioDeviceModule* audio_device_module() override {
42 return shared_->audio_device(); 36 return shared_->audio_device();
43 } 37 }
44 voe::TransmitMixer* transmit_mixer() override { 38 voe::TransmitMixer* transmit_mixer() override {
45 return shared_->transmit_mixer(); 39 return shared_->transmit_mixer();
46 } 40 }
47 int Terminate() override; 41 int Terminate() override;
48 42
49 int CreateChannel() override; 43 int CreateChannel() override;
50 int CreateChannel(const ChannelConfig& config) override; 44 int CreateChannel(const ChannelConfig& config) override;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 void* audio_data, int64_t* elapsed_time_ms, 111 void* audio_data, int64_t* elapsed_time_ms,
118 int64_t* ntp_time_ms); 112 int64_t* ntp_time_ms);
119 113
120 // Initialize channel by setting Engine Information then initializing 114 // Initialize channel by setting Engine Information then initializing
121 // channel. 115 // channel.
122 int InitializeChannel(voe::ChannelOwner* channel_owner); 116 int InitializeChannel(voe::ChannelOwner* channel_owner);
123 VoiceEngineObserver* voiceEngineObserverPtr_; 117 VoiceEngineObserver* voiceEngineObserverPtr_;
124 rtc::CriticalSection callbackCritSect_; 118 rtc::CriticalSection callbackCritSect_;
125 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_; 119 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
126 120
127 // TODO(peah): Remove this when upstream dependencies have properly been
128 // resolved.
129 rtc::scoped_refptr<AudioProcessing> audio_processing_;
130
131 AudioFrame audioFrame_; 121 AudioFrame audioFrame_;
132 voe::SharedData* shared_; 122 voe::SharedData* shared_;
133 }; 123 };
134 124
135 } // namespace webrtc 125 } // namespace webrtc
136 126
137 #endif // WEBRTC_VOICE_ENGINE_VOE_BASE_IMPL_H 127 #endif // WEBRTC_VOICE_ENGINE_VOE_BASE_IMPL_H
OLDNEW
« no previous file with comments | « webrtc/voice_engine/include/voe_base.h ('k') | webrtc/voice_engine/voe_base_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698