Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2967453002: Actually use virtual network in OrtcFactory unit test. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Actually use virtual network in OrtcFactory unit test. I intended to do this originally, but just forgot to pass the thread with the virtual socket server into OrtcFactory::Create... BUG=None TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2967453002 Cr-Commit-Position: refs/heads/master@{#18831} Committed: https://chromium.googlesource.com/external/webrtc/+/57ca81aff0cb4a0cca8b2e2d80e73e9ae0fa1f63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/ortc/ortcfactory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Taylor Brandstetter
3 years, 5 months ago (2017-06-29 11:47:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2967453002/1
3 years, 5 months ago (2017-06-29 11:48:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/57ca81aff0cb4a0cca8b2e2d80e73e9ae0fa1f63
3 years, 5 months ago (2017-06-29 12:34:50 UTC) #12
pthatcher1
3 years, 5 months ago (2017-06-30 13:58:02 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698