Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Side by Side Diff: webrtc/ortc/ortcfactory_unittest.cc

Issue 2967453002: Actually use virtual network in OrtcFactory unit test. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 // This test uses a virtual network and fake media engine, in order to test the 23 // This test uses a virtual network and fake media engine, in order to test the
24 // OrtcFactory at only an API level. Any end-to-end test should go in 24 // OrtcFactory at only an API level. Any end-to-end test should go in
25 // ortcfactory_integrationtest.cc instead. 25 // ortcfactory_integrationtest.cc instead.
26 class OrtcFactoryTest : public testing::Test { 26 class OrtcFactoryTest : public testing::Test {
27 public: 27 public:
28 OrtcFactoryTest() 28 OrtcFactoryTest()
29 : thread_(&virtual_socket_server_), 29 : thread_(&virtual_socket_server_),
30 fake_packet_transport_("fake transport") { 30 fake_packet_transport_("fake transport") {
31 ortc_factory_ = 31 ortc_factory_ =
32 OrtcFactory::Create(nullptr, nullptr, &fake_network_manager_, nullptr, 32 OrtcFactory::Create(&thread_, nullptr, &fake_network_manager_, nullptr,
33 nullptr, 33 nullptr,
34 std::unique_ptr<cricket::MediaEngineInterface>( 34 std::unique_ptr<cricket::MediaEngineInterface>(
35 new cricket::FakeMediaEngine())) 35 new cricket::FakeMediaEngine()))
36 .MoveValue(); 36 .MoveValue();
37 } 37 }
38 38
39 protected: 39 protected:
40 // Uses a single pre-made FakePacketTransport, so shouldn't be called twice in 40 // Uses a single pre-made FakePacketTransport, so shouldn't be called twice in
41 // the same test. 41 // the same test.
42 std::unique_ptr<RtpTransportInterface> 42 std::unique_ptr<RtpTransportInterface>
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 TEST_F(OrtcFactoryTest, CreateSendersOrReceieversWithNullTransport) { 246 TEST_F(OrtcFactoryTest, CreateSendersOrReceieversWithNullTransport) {
247 auto sender_result = 247 auto sender_result =
248 ortc_factory_->CreateRtpSender(cricket::MEDIA_TYPE_AUDIO, nullptr); 248 ortc_factory_->CreateRtpSender(cricket::MEDIA_TYPE_AUDIO, nullptr);
249 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, sender_result.error().type()); 249 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, sender_result.error().type());
250 auto receiver_result = 250 auto receiver_result =
251 ortc_factory_->CreateRtpReceiver(cricket::MEDIA_TYPE_AUDIO, nullptr); 251 ortc_factory_->CreateRtpReceiver(cricket::MEDIA_TYPE_AUDIO, nullptr);
252 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, receiver_result.error().type()); 252 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, receiver_result.error().type());
253 } 253 }
254 254
255 } // namespace webrtc 255 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698