Fix FecTest.FlexfecTest flakiness caused by seq. num. wraparound.

Fix FecTest.FlexfecTest flakiness caused by seq. num. wraparound.

The CL in https://codereview.webrtc.org/2918333002/ enabled
FecTest.FlexfecTest and also added a sequence number offset between
the FEC packets and the media packets. This was to simulate that the
sequence numbers were generated from different spaces, i.e., that they
belong to different SSRCs.

The test does not account for sequence number wraparound, which means
that it could fail when the sequence number offset realization was large.
This CL fixes the problem by ensuring that the offset always lies in
[0, 2^15].

This CL also fixes spelling of UlpfecTest.

BUG=webrtc:7912
TESTED=ninja -C out/Debug && third_party/gtest-parallel/gtest-parallel --gtest_filter="*Flexfec*" -r 1000 out/Debug/modules_tests

Review-Url: https://codereview.webrtc.org/2966753002
Cr-Commit-Position: refs/heads/master@{#18863}
Committed: https://chromium.googlesource.com/external/webrtc/+/fa8567868ecaa869e976f780d799062fb1aee915

[brandtr, 2017-06-30 12:53:00]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 12:53:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 12:58:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 12:58:13]

Dry run: Try jobs failed on following builders:
  win_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/20230)
  win_x64_clang_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_rel/build...)

[brandtr, 2017-06-30 13:00:12]

brandtr@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2017-06-30 13:04:55]

Some compile errors to fix, but otherwise this lgtm

[brandtr, 2017-06-30 13:10:59]

On 2017/06/30 13:04:55, stefan-webrtc wrote:
> Some compile errors to fix, but otherwise this lgtm

The whole tree is red for Windows :)
https://build.chromium.org/p/client.webrtc/console

[brandtr, 2017-06-30 13:24:28]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-06-30 13:24:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 14:22:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498829068334890, "parent_rev":
"697a5903148af9da80d815212387563eac4c5052", "commit_rev":
"fa8567868ecaa869e976f780d799062fb1aee915"}

[commit-bot: I haz the power, 2017-06-30 14:22:19]

Description was changed from

==========
Fix FecTest.FlexfecTest flakiness caused by seq. num. wraparound.

The CL in https://codereview.webrtc.org/2918333002/ enabled
FecTest.FlexfecTest and also added a sequence number offset between
the FEC packets and the media packets. This was to simulate that the
sequence numbers were generated from different spaces, i.e., that they
belong to different SSRCs.

The test does not account for sequence number wraparound, which means
that it could fail when the sequence number offset realization was large.
This CL fixes the problem by ensuring that the offset always lies in
[0, 2^15].

This CL also fixes spelling of UlpfecTest.

BUG=webrtc:7912
TESTED=ninja -C out/Debug && third_party/gtest-parallel/gtest-parallel
--gtest_filter="*Flexfec*" -r 1000 out/Debug/modules_tests
==========

to

==========
Fix FecTest.FlexfecTest flakiness caused by seq. num. wraparound.

The CL in https://codereview.webrtc.org/2918333002/ enabled
FecTest.FlexfecTest and also added a sequence number offset between
the FEC packets and the media packets. This was to simulate that the
sequence numbers were generated from different spaces, i.e., that they
belong to different SSRCs.

The test does not account for sequence number wraparound, which means
that it could fail when the sequence number offset realization was large.
This CL fixes the problem by ensuring that the offset always lies in
[0, 2^15].

This CL also fixes spelling of UlpfecTest.

BUG=webrtc:7912
TESTED=ninja -C out/Debug && third_party/gtest-parallel/gtest-parallel
--gtest_filter="*Flexfec*" -r 1000 out/Debug/modules_tests

Review-Url: https://codereview.webrtc.org/2966753002
Cr-Commit-Position: refs/heads/master@{#18863}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fa8567868ecaa869e976f780d...
==========

[commit-bot: I haz the power, 2017-06-30 14:22:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fa8567868ecaa869e976f780d...