Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc

Issue 2966753002: Fix FecTest.FlexfecTest flakiness caused by seq. num. wraparound. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc b/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
index a65e8a684f2ab8bf0b1f7ffd0a005d1790a2868f..b23a5f5f9b8e1d14326b67942eb59ff08a69170e 100644
--- a/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
+++ b/webrtc/modules/rtp_rtcp/test/testFec/test_fec.cc
@@ -135,7 +135,7 @@ void RunTest(bool use_flexfec) {
uint16_t fec_seq_num_offset;
if (use_flexfec) {
fec_ssrc = random.Rand(1u, 0xfffffffe);
- fec_seq_num_offset = random.Rand<uint16_t>();
+ fec_seq_num_offset = random.Rand(0, 1 << 15);
} else {
fec_ssrc = media_ssrc;
fec_seq_num_offset = 0;
@@ -465,13 +465,13 @@ void RunTest(bool use_flexfec) {
// Too slow to finish before timeout on iOS. See webrtc:4755.
#if defined(WEBRTC_IOS)
-#define MAYBE_UlpecTest DISABLED_UlpecTest
+#define MAYBE_UlpfecTest DISABLED_UlpfecTest
#define MAYBE_FlexfecTest DISABLED_FlexfecTest
#else
-#define MAYBE_UlpecTest UlpecTest
+#define MAYBE_UlpfecTest UlpfecTest
#define MAYBE_FlexfecTest FlexfecTest
#endif
-TEST(FecTest, MAYBE_UlpecTest) {
+TEST(FecTest, MAYBE_UlpfecTest) {
RunTest(false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698