Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2966733002: Add received interframe delay UMA metrics (Closed)

Created:
3 years, 5 months ago by ilnik
Modified:
3 years, 5 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add received interframe delay UMA metrics BUG=webrtc:7420 Review-Url: https://codereview.webrtc.org/2966733002 Cr-Commit-Position: refs/heads/master@{#18875} Committed: https://chromium.googlesource.com/external/webrtc/+/4257ab2e0281f248d25726b4917f8aa47b01547c

Patch Set 1 #

Patch Set 2 : Add initialization #

Total comments: 2

Patch Set 3 : Implement Sprang@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M webrtc/video/end_to_end_tests.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 1 2 3 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ilnik
3 years, 5 months ago (2017-06-30 08:53:33 UTC) #2
sprang_webrtc
lgtm with nit https://codereview.webrtc.org/2966733002/diff/20001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/2966733002/diff/20001/webrtc/video/receive_statistics_proxy.cc#newcode556 webrtc/video/receive_statistics_proxy.cc:556: if (interframe_delay_max_ms_screenshare_ == -1 || Skip ...
3 years, 5 months ago (2017-06-30 21:43:02 UTC) #7
ilnik
https://codereview.webrtc.org/2966733002/diff/20001/webrtc/video/receive_statistics_proxy.cc File webrtc/video/receive_statistics_proxy.cc (right): https://codereview.webrtc.org/2966733002/diff/20001/webrtc/video/receive_statistics_proxy.cc#newcode556 webrtc/video/receive_statistics_proxy.cc:556: if (interframe_delay_max_ms_screenshare_ == -1 || On 2017/06/30 21:43:02, sprang_webrtc ...
3 years, 5 months ago (2017-07-03 07:53:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2966733002/40001
3 years, 5 months ago (2017-07-03 07:53:32 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 08:16:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/4257ab2e0281f248d25726b49...

Powered by Google App Engine
This is Rietveld 408576698