Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2966733002: Add received interframe delay UMA metrics (Closed)
Patch Set: Implement Sprang@ comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 2685 matching lines...) Expand 10 before | Expand all | Expand 10 after
2696 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.DecodedFramesPerSecond")); 2696 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.DecodedFramesPerSecond"));
2697 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.RenderFramesPerSecond")); 2697 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.RenderFramesPerSecond"));
2698 2698
2699 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.JitterBufferDelayInMs")); 2699 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.JitterBufferDelayInMs"));
2700 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.TargetDelayInMs")); 2700 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.TargetDelayInMs"));
2701 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.CurrentDelayInMs")); 2701 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.CurrentDelayInMs"));
2702 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.OnewayDelayInMs")); 2702 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.OnewayDelayInMs"));
2703 2703
2704 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "EndToEndDelayInMs")); 2704 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "EndToEndDelayInMs"));
2705 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "EndToEndDelayMaxInMs")); 2705 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "EndToEndDelayMaxInMs"));
2706 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "InterframeDelayInMs"));
2707 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "InterframeDelayMaxInMs"));
2708
2706 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.RenderSqrtPixelsPerSecond")); 2709 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.RenderSqrtPixelsPerSecond"));
2707 2710
2708 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "EncodeTimeInMs")); 2711 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "EncodeTimeInMs"));
2709 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.DecodeTimeInMs")); 2712 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.DecodeTimeInMs"));
2710 2713
2711 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "NumberOfPauseEvents")); 2714 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "NumberOfPauseEvents"));
2712 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "PausedTimeInPercent")); 2715 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "PausedTimeInPercent"));
2713 2716
2714 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "BitrateSentInKbps")); 2717 EXPECT_EQ(1, metrics::NumSamples(video_prefix + "BitrateSentInKbps"));
2715 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.BitrateReceivedInKbps")); 2718 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.BitrateReceivedInKbps"));
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
2854 sender_call_.reset(); 2857 sender_call_.reset();
2855 receiver_call_.reset(); 2858 receiver_call_.reset();
2856 2859
2857 // Verify that stats have been updated for both screenshare and video. 2860 // Verify that stats have been updated for both screenshare and video.
2858 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.EndToEndDelayInMs")); 2861 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.EndToEndDelayInMs"));
2859 EXPECT_EQ(1, 2862 EXPECT_EQ(1,
2860 metrics::NumSamples("WebRTC.Video.Screenshare.EndToEndDelayInMs")); 2863 metrics::NumSamples("WebRTC.Video.Screenshare.EndToEndDelayInMs"));
2861 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.EndToEndDelayMaxInMs")); 2864 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.EndToEndDelayMaxInMs"));
2862 EXPECT_EQ( 2865 EXPECT_EQ(
2863 1, metrics::NumSamples("WebRTC.Video.Screenshare.EndToEndDelayMaxInMs")); 2866 1, metrics::NumSamples("WebRTC.Video.Screenshare.EndToEndDelayMaxInMs"));
2867 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.InterframeDelayInMs"));
2868 EXPECT_EQ(1,
2869 metrics::NumSamples(
2870 "WebRTC.Video.Screenshare.InterframeDelayInMs"));
2871 EXPECT_EQ(1, metrics::NumSamples("WebRTC.Video.InterframeDelayMaxInMs"));
2872 EXPECT_EQ(1,
2873 metrics::NumSamples(
2874 "WebRTC.Video.Screenshare.InterframeDelayMaxInMs"));
2864 } 2875 }
2865 2876
2866 TEST_F(EndToEndTest, VerifyHistogramStatsWithRtx) { 2877 TEST_F(EndToEndTest, VerifyHistogramStatsWithRtx) {
2867 const bool kEnabledRtx = true; 2878 const bool kEnabledRtx = true;
2868 const bool kEnabledRed = false; 2879 const bool kEnabledRed = false;
2869 const bool kScreenshare = false; 2880 const bool kScreenshare = false;
2870 VerifyHistogramStats(kEnabledRtx, kEnabledRed, kScreenshare); 2881 VerifyHistogramStats(kEnabledRtx, kEnabledRed, kScreenshare);
2871 } 2882 }
2872 2883
2873 TEST_F(EndToEndTest, VerifyHistogramStatsWithRed) { 2884 TEST_F(EndToEndTest, VerifyHistogramStatsWithRed) {
(...skipping 1817 matching lines...) Expand 10 before | Expand all | Expand 10 after
4691 std::unique_ptr<VideoEncoder> encoder_; 4702 std::unique_ptr<VideoEncoder> encoder_;
4692 std::unique_ptr<VideoDecoder> decoder_; 4703 std::unique_ptr<VideoDecoder> decoder_;
4693 rtc::CriticalSection crit_; 4704 rtc::CriticalSection crit_;
4694 int recorded_frames_ GUARDED_BY(crit_); 4705 int recorded_frames_ GUARDED_BY(crit_);
4695 } test(this); 4706 } test(this);
4696 4707
4697 RunBaseTest(&test); 4708 RunBaseTest(&test);
4698 } 4709 }
4699 4710
4700 } // namespace webrtc 4711 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698