Reland of Create RtcpDemuxer

Reland of Create RtcpDemuxer (patchset #1 id:1 of https://codereview.webrtc.org/2957763002/ )

Reason for revert:
About to fix problem and reland.

Original issue's description:
> Revert of Create RtcpDemuxer (patchset #13 id:240001 of https://codereview.webrtc.org/2943693003/ )
> 
> Reason for revert:
> Breaks Chromium FYI bots.
> 
> The problem is in the BUILD.gn file.
> 
> Sample failure:
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/17829
> 
> Sample logs:
> use_goma = true
> """ to /b/c/b/Linux_Builder/src/out/Release/args.gn.
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //third_party/webrtc/call/BUILD.gn:46:5: Can't load input file.
>     "//webrtc/base:rtc_base_approved",
>     ^--------------------------------
> 
> Original issue's description:
> > Create RtcpDemuxer. Capabilities:
> > 1. Demux RTCP messages according to the sender-SSRC.
> > 2. Demux RTCP messages according to the RSID (resolved to an SSRC, then compared to the sender-RTCP).
> > 3. Allow listening in on all RTCP messages passing through the demuxer ("broadcast sinks").
> > 
> > BUG=webrtc:7135
> > 
> > Review-Url: https://codereview.webrtc.org/2943693003
> > Cr-Commit-Position: refs/heads/master@{#18763}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/cb83bdf01f2ec8b9ed254991edc2be053c9eed24
> 
> BUG=webrtc:7135
> 
> Review-Url: https://codereview.webrtc.org/2957763002
> Cr-Commit-Position: refs/heads/master@{#18764}
> Committed: https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02fb396d70748474ed

BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2960623002
Cr-Commit-Position: refs/heads/master@{#18768}
Committed: https://chromium.googlesource.com/external/webrtc/+/a52722fac401ae44fcc3fc67f9dd3055a18ea4ef

[eladalon, 2017-06-26 13:58:41]

Created Reland of Create RtcpDemuxer

[eladalon, 2017-06-26 14:07:10]

Description was changed from

==========
Reland of Create RtcpDemuxer (patchset #1 id:1 of
https://codereview.webrtc.org/2957763002/ )

Reason for revert:
About to fix problem and reland.

Original issue's description:
> Revert of Create RtcpDemuxer (patchset #13 id:240001 of
https://codereview.webrtc.org/2943693003/ )
> 
> Reason for revert:
> Breaks Chromium FYI bots.
> 
> The problem is in the BUILD.gn file.
> 
> Sample failure:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
> 
> Sample logs:
> use_goma = true
> """ to /b/c/b/Linux_Builder/src/out/Release/args.gn.
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //third_party/webrtc/call/BUILD.gn:46:5: Can't load input file.
>     "//webrtc/base:rtc_base_approved",
>     ^--------------------------------
> 
> Original issue's description:
> > Create RtcpDemuxer. Capabilities:
> > 1. Demux RTCP messages according to the sender-SSRC.
> > 2. Demux RTCP messages according to the RSID (resolved to an SSRC, then
compared to the sender-RTCP).
> > 3. Allow listening in on all RTCP messages passing through the demuxer
("broadcast sinks").
> > 
> > BUG=webrtc:7135
> > 
> > Review-Url: https://codereview.webrtc.org/2943693003
> > Cr-Commit-Position: refs/heads/master@{#18763}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/cb83bdf01f2ec8b9ed254991e...
> 
>
TBR=stefan@webrtc.org,danilchap@webrtc.org,nisse@webrtc.org,kjellander@webrtc...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7135
> 
> Review-Url: https://codereview.webrtc.org/2957763002
> Cr-Commit-Position: refs/heads/master@{#18764}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02f...

TBR=stefan@webrtc.org,danilchap@webrtc.org,nisse@webrtc.org,kjellander@webrtc...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7135
==========

to

==========
Reland of Create RtcpDemuxer (patchset #1 id:1 of
https://codereview.webrtc.org/2957763002/ )

Reason for revert:
About to fix problem and reland.

Original issue's description:
> Revert of Create RtcpDemuxer (patchset #13 id:240001 of
https://codereview.webrtc.org/2943693003/ )
> 
> Reason for revert:
> Breaks Chromium FYI bots.
> 
> The problem is in the BUILD.gn file.
> 
> Sample failure:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
> 
> Sample logs:
> use_goma = true
> """ to /b/c/b/Linux_Builder/src/out/Release/args.gn.
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //third_party/webrtc/call/BUILD.gn:46:5: Can't load input file.
>     "//webrtc/base:rtc_base_approved",
>     ^--------------------------------
> 
> Original issue's description:
> > Create RtcpDemuxer. Capabilities:
> > 1. Demux RTCP messages according to the sender-SSRC.
> > 2. Demux RTCP messages according to the RSID (resolved to an SSRC, then
compared to the sender-RTCP).
> > 3. Allow listening in on all RTCP messages passing through the demuxer
("broadcast sinks").
> > 
> > BUG=webrtc:7135
> > 
> > Review-Url: https://codereview.webrtc.org/2943693003
> > Cr-Commit-Position: refs/heads/master@{#18763}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/cb83bdf01f2ec8b9ed254991e...
> 
> BUG=webrtc:7135
> 
> Review-Url: https://codereview.webrtc.org/2957763002
> Cr-Commit-Position: refs/heads/master@{#18764}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02f...

BUG=webrtc:7135
==========

[stefan-webrtc, 2017-06-26 14:34:28]

Was it just the change to BUILD.gn that was needed to fix the issue?

[eladalon, 2017-06-26 14:36:45]

On 2017/06/26 14:34:28, stefan-webrtc wrote:
> Was it just the change to BUILD.gn that was needed to fix the issue?

Yes. (Whether it fixes is up for the chromium bots to decide, but I believe it
will be okay.)
If you lgtm-ize, and I see it requires additional changes, I can ping you before
actually landing.

[stefan-webrtc, 2017-06-26 18:03:08]

lgtm

[eladalon, 2017-06-26 18:08:14]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-06-26 18:08:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-26 18:23:54]

CQ is committing da patch.

Bot data: {"patchset_id": 350001, "attempt_start_ts": 1498500494715920,
"parent_rev": "376b6fd483cc61171b5876156b0c675dba906b4f", "commit_rev":
"a52722fac401ae44fcc3fc67f9dd3055a18ea4ef"}

[commit-bot: I haz the power, 2017-06-26 18:24:02]

Description was changed from

==========
Reland of Create RtcpDemuxer (patchset #1 id:1 of
https://codereview.webrtc.org/2957763002/ )

Reason for revert:
About to fix problem and reland.

Original issue's description:
> Revert of Create RtcpDemuxer (patchset #13 id:240001 of
https://codereview.webrtc.org/2943693003/ )
> 
> Reason for revert:
> Breaks Chromium FYI bots.
> 
> The problem is in the BUILD.gn file.
> 
> Sample failure:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
> 
> Sample logs:
> use_goma = true
> """ to /b/c/b/Linux_Builder/src/out/Release/args.gn.
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //third_party/webrtc/call/BUILD.gn:46:5: Can't load input file.
>     "//webrtc/base:rtc_base_approved",
>     ^--------------------------------
> 
> Original issue's description:
> > Create RtcpDemuxer. Capabilities:
> > 1. Demux RTCP messages according to the sender-SSRC.
> > 2. Demux RTCP messages according to the RSID (resolved to an SSRC, then
compared to the sender-RTCP).
> > 3. Allow listening in on all RTCP messages passing through the demuxer
("broadcast sinks").
> > 
> > BUG=webrtc:7135
> > 
> > Review-Url: https://codereview.webrtc.org/2943693003
> > Cr-Commit-Position: refs/heads/master@{#18763}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/cb83bdf01f2ec8b9ed254991e...
> 
> BUG=webrtc:7135
> 
> Review-Url: https://codereview.webrtc.org/2957763002
> Cr-Commit-Position: refs/heads/master@{#18764}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02f...

BUG=webrtc:7135
==========

to

==========
Reland of Create RtcpDemuxer (patchset #1 id:1 of
https://codereview.webrtc.org/2957763002/ )

Reason for revert:
About to fix problem and reland.

Original issue's description:
> Revert of Create RtcpDemuxer (patchset #13 id:240001 of
https://codereview.webrtc.org/2943693003/ )
> 
> Reason for revert:
> Breaks Chromium FYI bots.
> 
> The problem is in the BUILD.gn file.
> 
> Sample failure:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
> 
> Sample logs:
> use_goma = true
> """ to /b/c/b/Linux_Builder/src/out/Release/args.gn.
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //third_party/webrtc/call/BUILD.gn:46:5: Can't load input file.
>     "//webrtc/base:rtc_base_approved",
>     ^--------------------------------
> 
> Original issue's description:
> > Create RtcpDemuxer. Capabilities:
> > 1. Demux RTCP messages according to the sender-SSRC.
> > 2. Demux RTCP messages according to the RSID (resolved to an SSRC, then
compared to the sender-RTCP).
> > 3. Allow listening in on all RTCP messages passing through the demuxer
("broadcast sinks").
> > 
> > BUG=webrtc:7135
> > 
> > Review-Url: https://codereview.webrtc.org/2943693003
> > Cr-Commit-Position: refs/heads/master@{#18763}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/cb83bdf01f2ec8b9ed254991e...
> 
> BUG=webrtc:7135
> 
> Review-Url: https://codereview.webrtc.org/2957763002
> Cr-Commit-Position: refs/heads/master@{#18764}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02f...

BUG=webrtc:7135

Review-Url: https://codereview.webrtc.org/2960623002
Cr-Commit-Position: refs/heads/master@{#18768}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a52722fac401ae44fcc3fc67f...
==========

[commit-bot: I haz the power, 2017-06-26 18:24:03]

Committed patchset #3 (id:350001) as
https://chromium.googlesource.com/external/webrtc/+/a52722fac401ae44fcc3fc67f...