Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2957763002: Revert of Create RtcpDemuxer (Closed)

Created:
3 years, 5 months ago by guidou
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Create RtcpDemuxer (patchset #13 id:240001 of https://codereview.webrtc.org/2943693003/ ) Reason for revert: Breaks Chromium FYI bots. The problem is in the BUILD.gn file. Sample failure: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/17829 Sample logs: use_goma = true """ to /b/c/b/Linux_Builder/src/out/Release/args.gn. /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //third_party/webrtc/call/BUILD.gn:46:5: Can't load input file. "//webrtc/base:rtc_base_approved", ^-------------------------------- Original issue's description: > Create RtcpDemuxer. Capabilities: > 1. Demux RTCP messages according to the sender-SSRC. > 2. Demux RTCP messages according to the RSID (resolved to an SSRC, then compared to the sender-RTCP). > 3. Allow listening in on all RTCP messages passing through the demuxer ("broadcast sinks"). > > BUG=webrtc:7135 > > Review-Url: https://codereview.webrtc.org/2943693003 > Cr-Commit-Position: refs/heads/master@{#18763} > Committed: https://chromium.googlesource.com/external/webrtc/+/cb83bdf01f2ec8b9ed254991edc2be053c9eed24 TBR=stefan@webrtc.org,danilchap@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org,holmer@google.com,eladalon@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/2957763002 Cr-Commit-Position: refs/heads/master@{#18764} Committed: https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02fb396d70748474ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1300 lines) Patch
M webrtc/call/BUILD.gn View 4 chunks +1 line, -14 lines 0 comments Download
D webrtc/call/rsid_resolution_observer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/call/rtcp_demuxer.h View 1 chunk +0 lines, -85 lines 0 comments Download
D webrtc/call/rtcp_demuxer.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/call/rtcp_demuxer_unittest.cc View 1 chunk +0 lines, -584 lines 0 comments Download
D webrtc/call/rtcp_packet_sink_interface.h View 1 chunk +0 lines, -29 lines 0 comments Download
M webrtc/call/rtp_demuxer.h View 4 chunks +4 lines, -22 lines 0 comments Download
M webrtc/call/rtp_demuxer.cc View 4 chunks +44 lines, -53 lines 0 comments Download
M webrtc/call/rtp_demuxer_unittest.cc View 7 chunks +11 lines, -140 lines 0 comments Download
M webrtc/call/rtp_packet_sink_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/call/rtp_rtcp_demuxer_helper.h View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/call/rtp_rtcp_demuxer_helper.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/call/rtp_rtcp_demuxer_helper_unittest.cc View 1 chunk +0 lines, -119 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
guidou
Created Revert of Create RtcpDemuxer
3 years, 5 months ago (2017-06-26 13:28:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2957763002/1
3 years, 5 months ago (2017-06-26 13:28:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0e7e7869e74a29caf8197d02fb396d70748474ed
3 years, 5 months ago (2017-06-26 13:28:41 UTC) #6
eladalon
3 years, 5 months ago (2017-06-26 13:58:40 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2960623002/ by eladalon@webrtc.org.

The reason for reverting is: About to fix problem and reland..

Powered by Google App Engine
This is Rietveld 408576698