Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2957303002: Fixing RTCIceCandidatePairStats.nominated for ICE controlling agent. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing RTCIceCandidatePairStats.nominated for ICE controlling agent. Was only working when the nonstandard "renomination" extension to ICE is enabled, which chromium doesn't use. BUG=chromium:734094 Review-Url: https://codereview.webrtc.org/2957303002 Cr-Commit-Position: refs/heads/master@{#18814} Committed: https://chromium.googlesource.com/external/webrtc/+/86c40a14b48c8eff0dd7af048f30747af2c61016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M webrtc/p2p/base/port.cc View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
PTAL
3 years, 5 months ago (2017-06-28 12:20:28 UTC) #2
pthatcher1
3 years, 5 months ago (2017-06-28 15:19:30 UTC) #3
pthatcher1
On 2017/06/28 15:19:30, pthatcher1 wrote: lgtm
3 years, 5 months ago (2017-06-28 16:16:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2957303002/1
3 years, 5 months ago (2017-06-28 16:16:30 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 16:37:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/86c40a14b48c8eff0dd7af048...

Powered by Google App Engine
This is Rietveld 408576698