Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2957303002: Fixing RTCIceCandidatePairStats.nominated for ICE controlling agent. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/port.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 verifier.TestMemberIsUndefined(candidate_pair.readable); 372 verifier.TestMemberIsUndefined(candidate_pair.readable);
373 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_sent); 373 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_sent);
374 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_received); 374 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_received);
375 verifier.TestMemberIsNonNegative<double>( 375 verifier.TestMemberIsNonNegative<double>(
376 candidate_pair.total_round_trip_time); 376 candidate_pair.total_round_trip_time);
377 verifier.TestMemberIsNonNegative<double>( 377 verifier.TestMemberIsNonNegative<double>(
378 candidate_pair.current_round_trip_time); 378 candidate_pair.current_round_trip_time);
379 if (is_selected_pair) { 379 if (is_selected_pair) {
380 verifier.TestMemberIsNonNegative<double>( 380 verifier.TestMemberIsNonNegative<double>(
381 candidate_pair.available_outgoing_bitrate); 381 candidate_pair.available_outgoing_bitrate);
382 // A pair should be nominated in order to be selected.
383 EXPECT_TRUE(*candidate_pair.nominated);
382 } else { 384 } else {
383 verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate); 385 verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
384 } 386 }
385 verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate); 387 verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
386 verifier.TestMemberIsNonNegative<uint64_t>( 388 verifier.TestMemberIsNonNegative<uint64_t>(
387 candidate_pair.requests_received); 389 candidate_pair.requests_received);
388 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent); 390 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent);
389 verifier.TestMemberIsNonNegative<uint64_t>( 391 verifier.TestMemberIsNonNegative<uint64_t>(
390 candidate_pair.responses_received); 392 candidate_pair.responses_received);
391 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.responses_sent); 393 verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.responses_sent);
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 caller_ = nullptr; 643 caller_ = nullptr;
642 // Any pending stats requests should have completed in the act of destroying 644 // Any pending stats requests should have completed in the act of destroying
643 // the peer connection. 645 // the peer connection.
644 EXPECT_TRUE(stats_obtainer->report()); 646 EXPECT_TRUE(stats_obtainer->report());
645 } 647 }
646 #endif // HAVE_SCTP 648 #endif // HAVE_SCTP
647 649
648 } // namespace 650 } // namespace
649 651
650 } // namespace webrtc 652 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/p2p/base/port.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698