Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2950453002: Opus implementation of the AudioDecoderFactoryTemplate API (Closed)

Created:
3 years, 6 months ago by kwiberg-webrtc
Modified:
3 years, 5 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Opus implementation of the AudioDecoderFactoryTemplate API (This got reverted because of a problem with the Opus encoder parts. Re-landing without changes.) BUG=webrtc:7837 Review-Url: https://codereview.webrtc.org/2950453002 Cr-Commit-Position: refs/heads/master@{#18855} Committed: https://chromium.googlesource.com/external/webrtc/+/96d74bb933fbe774a6324dc738c113fb5c684c0e

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 17 (13 generated)
kwiberg-webrtc
3 years, 6 months ago (2017-06-19 04:39:18 UTC) #6
ossu
So there were no downstream issues with the decoder part? Either way, lgtm!
3 years, 5 months ago (2017-06-30 09:15:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2950453002/20001
3 years, 5 months ago (2017-06-30 12:21:22 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 12:25:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/96d74bb933fbe774a6324dc73...

Powered by Google App Engine
This is Rietveld 408576698