Opus implementation of the AudioEncoderFactoryTemplate API

Opus implementation of the AudioEncoderFactoryTemplate API

This was previously reverted, because external projects were using the
internal webrtc::AudioEncoderOpus class and broke when it was renamed.
This re-land avoids renaming it immediately, to give those projects
time to adapt. It also has to revert some of the changes I had made to the
Config struct, since that was also used by the same external projects.

BUG=webrtc:7831
Review-Url: https://codereview.webrtc.org/2948483002
Cr-Commit-Position: refs/heads/master@{#18852}
Committed: https://chromium.googlesource.com/external/webrtc/+/96da0115d78f0978876b734ed2d169373b7ae7a0

[kwiberg-webrtc, 2017-06-18 14:31:45]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 14:31:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-06-18 14:51:54]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 14:52:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-18 15:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-18 15:13:31]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-06-18 17:00:32]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 17:00:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-06-18 17:01:06]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-06-18 17:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-18 17:22:12]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-06-18 19:40:12]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 19:40:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-06-18 19:58:58]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-18 19:59:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-18 20:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-18 20:18:57]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-06-18 21:04:10]

Patchset #2 (id:40001) has been deleted

[kwiberg-webrtc, 2017-06-18 21:04:32]

Patchset #2 (id:60001) has been deleted

[kwiberg-webrtc, 2017-06-18 21:07:14]

Description was changed from

==========
Opus implementation of the AudioEncoderFactoryTemplate API

This was previously reverted, because external projects were using the
internal webrtc::AudioEncoderOpus class and broke when it was renamed.
This re-land avoids renaming it immediately, to give those projects
time to adapt.

BUG=webrtc:7831
==========

to

==========
Opus implementation of the AudioEncoderFactoryTemplate API

This was previously reverted, because external projects were using the
internal webrtc::AudioEncoderOpus class and broke when it was renamed.
This re-land avoids renaming it immediately, to give those projects
time to adapt. It also has to revert some of the changes I had made to the
Config struct, since that was also used by the same external projects.

BUG=webrtc:7831
==========

[kwiberg-webrtc, 2017-06-18 21:07:14]

kwiberg@webrtc.org changed reviewers:
+ ossu@webrtc.org, solenberg@webrtc.org

[kwiberg-webrtc, 2017-06-18 21:08:32]

OK, got this to work after a number of iterations. The linux-internal bot is
still red, but the remaining test failure isn't this CL's fault AFAICT.

[kwiberg-webrtc, 2017-06-22 13:29:16]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 13:29:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-22 13:32:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 13:32:13]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/25722)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/22568)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/26818)

[kwiberg-webrtc, 2017-06-26 02:31:21]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 02:31:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-26 03:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 03:08:27]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[kwiberg-webrtc, 2017-06-26 03:09:46]

PTAL. I think what you'll want to look at is either the full thing, or the PS#3
vs. PS#1 diff (the changes relative to what I tried to land last time).

[ossu, 2017-06-30 09:11:13]

lgtm!

[kwiberg-webrtc, 2017-06-30 10:29:07]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-06-30 10:29:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 10:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 10:30:41]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/21389)

[kwiberg-webrtc, 2017-06-30 10:43:21]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2017-06-30 10:43:22]

The patchset sent to the CQ was uploaded after l-g-t-m from ossu@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2948483002/#ps180001 (title:
"rebase")

[commit-bot: I haz the power, 2017-06-30 10:43:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 10:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 10:50:01]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18741)

[kwiberg-webrtc, 2017-06-30 11:20:38]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-06-30 11:20:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 11:23:23]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1498821638627600,
"parent_rev": "41bafb2f2dc373c4db9b7c4431a8fa88c9daf1f4", "commit_rev":
"96da0115d78f0978876b734ed2d169373b7ae7a0"}

[commit-bot: I haz the power, 2017-06-30 11:23:27]

Description was changed from

==========
Opus implementation of the AudioEncoderFactoryTemplate API

This was previously reverted, because external projects were using the
internal webrtc::AudioEncoderOpus class and broke when it was renamed.
This re-land avoids renaming it immediately, to give those projects
time to adapt. It also has to revert some of the changes I had made to the
Config struct, since that was also used by the same external projects.

BUG=webrtc:7831
==========

to

==========
Opus implementation of the AudioEncoderFactoryTemplate API

This was previously reverted, because external projects were using the
internal webrtc::AudioEncoderOpus class and broke when it was renamed.
This re-land avoids renaming it immediately, to give those projects
time to adapt. It also has to revert some of the changes I had made to the
Config struct, since that was also used by the same external projects.

BUG=webrtc:7831

Review-Url: https://codereview.webrtc.org/2948483002
Cr-Commit-Position: refs/heads/master@{#18852}
Committed:
https://chromium.googlesource.com/external/webrtc/+/96da0115d78f0978876b734ed...
==========

[commit-bot: I haz the power, 2017-06-30 11:23:28]

Committed patchset #7 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/96da0115d78f0978876b734ed...