Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2948483002: Opus implementation of the AudioEncoderFactoryTemplate API (Closed)

Created:
3 years, 6 months ago by kwiberg-webrtc
Modified:
3 years, 5 months ago
Reviewers:
the sun, ossu
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Opus implementation of the AudioEncoderFactoryTemplate API This was previously reverted, because external projects were using the internal webrtc::AudioEncoderOpus class and broke when it was renamed. This re-land avoids renaming it immediately, to give those projects time to adapt. It also has to revert some of the changes I had made to the Config struct, since that was also used by the same external projects. BUG=webrtc:7831 Review-Url: https://codereview.webrtc.org/2948483002 Cr-Commit-Position: refs/heads/master@{#18852} Committed: https://chromium.googlesource.com/external/webrtc/+/96da0115d78f0978876b734ed2d169373b7ae7a0

Patch Set 1 : The original CL #

Patch Set 2 : fix #

Patch Set 3 : ossu's idea #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : source_set #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -247 lines) Patch
M webrtc/api/DEPS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/opus/BUILD.gn View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/opus/audio_encoder_opus.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/opus/audio_encoder_opus_config.h View 1 1 chunk +73 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/opus/audio_encoder_opus_config.cc View 1 1 chunk +70 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc View 1 2 3 4 5 6 2 chunks +23 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 3 4 5 6 3 chunks +2 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 1 2 6 chunks +40 lines, -56 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 2 22 chunks +125 lines, -100 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 2 8 chunks +78 lines, -73 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 2 3 4 5 6 4 chunks +7 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 46 (37 generated)
kwiberg-webrtc
OK, got this to work after a number of iterations. The linux-internal bot is still ...
3 years, 6 months ago (2017-06-18 21:08:32 UTC) #22
kwiberg-webrtc
PTAL. I think what you'll want to look at is either the full thing, or ...
3 years, 5 months ago (2017-06-26 03:09:46 UTC) #31
ossu
lgtm!
3 years, 5 months ago (2017-06-30 09:11:13 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2948483002/160001
3 years, 5 months ago (2017-06-30 10:29:10 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/5659) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 5 months ago (2017-06-30 10:30:41 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2948483002/180001
3 years, 5 months ago (2017-06-30 10:43:31 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18741)
3 years, 5 months ago (2017-06-30 10:50:01 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2948483002/180001
3 years, 5 months ago (2017-06-30 11:20:42 UTC) #43
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 11:23:28 UTC) #46
Message was sent while issue was closed.
Committed patchset #7 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/96da0115d78f0978876b734ed...

Powered by Google App Engine
This is Rietveld 408576698