Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2949953003: Revert of Try to fix the binary size increase issue on Chromium. (Closed)

Created:
3 years, 6 months ago by Zhi Huang
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sakal
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Try to fix the binary size increase issue on Chromium. (patchset #1 id:1 of https://codereview.webrtc.org/2945233002/ ) Reason for revert: The Android 32 (more config) bot is broken. Original issue's description: > Try to fix the binary size increase issue on Chromium. > > The target common_video used to depend on rtc_media_base which introduces > the dependency on p2p. This probably causes the binary size increase on Win > Chromium. Some chromium targets like src/media/gpu:gpu depends on common_video directly. > > BUG=chromium:734631 > > Review-Url: https://codereview.webrtc.org/2945233002 > Cr-Commit-Position: refs/heads/master@{#18693} > Committed: https://chromium.googlesource.com/external/webrtc/+/9ed16097375fb8d9b45623c58d9086d33e503760 TBR=kjellander@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:734631 Review-Url: https://codereview.webrtc.org/2949953003 Cr-Commit-Position: refs/heads/master@{#18694} Committed: https://chromium.googlesource.com/external/webrtc/+/c2e208a9249452590fa282ef5aba43e480bc5794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/BUILD.gn View 3 chunks +2 lines, -19 lines 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhi Huang
Created Revert of Try to fix the binary size increase issue on Chromium.
3 years, 6 months ago (2017-06-21 07:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2949953003/1
3 years, 6 months ago (2017-06-21 07:30:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c2e208a9249452590fa282ef5aba43e480bc5794
3 years, 6 months ago (2017-06-21 07:30:57 UTC) #6
Zhi Huang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2949883003/ by zhihuang@webrtc.org. ...
3 years, 6 months ago (2017-06-21 08:02:43 UTC) #7
kjellander_webrtc
3 years, 6 months ago (2017-06-21 08:13:48 UTC) #8
Message was sent while issue was closed.
Thanks for acting quickly, but in this case it was actually a flake in the
compilation. Those are rare but can happen unfortunately.
In the future, I suggest forcing a new build (you need to view an internal URL
to see the force button though) before reverting in such cases.

Powered by Google App Engine
This is Rietveld 408576698