Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 2945233002: Try to fix the binary size increase issue on Chromium. (Closed)

Created:
3 years, 6 months ago by Zhi Huang
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sakal
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Try to fix the binary size increase issue on Chromium. The target common_video used to depend on rtc_media_base which introduces the dependency on p2p. This probably causes the binary size increase on Win Chromium. Some chromium targets like src/media/gpu:gpu depends on common_video directly. BUG=chromium:734631 Review-Url: https://codereview.webrtc.org/2945233002 Cr-Commit-Position: refs/heads/master@{#18693} Committed: https://chromium.googlesource.com/external/webrtc/+/9ed16097375fb8d9b45623c58d9086d33e503760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/BUILD.gn View 3 chunks +19 lines, -2 lines 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Zhi Huang
Please take a look. This is my fix for the Chromium binary size increase issue ...
3 years, 6 months ago (2017-06-21 06:22:17 UTC) #3
kjellander_webrtc
lgtm Always use prefixes for BUG= to be sure it gets posted. I updated it ...
3 years, 6 months ago (2017-06-21 06:32:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2945233002/1
3 years, 6 months ago (2017-06-21 06:35:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2945233002/1
3 years, 6 months ago (2017-06-21 06:36:46 UTC) #12
kjellander_webrtc
+sakal Sami: as WebRTC-in-Chrome sheriff, can you roll this into Chromium asap if the chromium.webrtc.fyi ...
3 years, 6 months ago (2017-06-21 06:40:03 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/9ed16097375fb8d9b45623c58d9086d33e503760
3 years, 6 months ago (2017-06-21 06:58:42 UTC) #16
Zhi Huang
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2949953003/ by zhihuang@webrtc.org. ...
3 years, 6 months ago (2017-06-21 07:30:36 UTC) #17
kjellander_webrtc
3 years, 6 months ago (2017-06-21 10:11:26 UTC) #19
Message was sent while issue was closed.
On 2017/06/21 07:30:36, Zhi Huang wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.webrtc.org/2949953003/ by mailto:zhihuang@webrtc.org.
> 
> The reason for reverting is: The Android 32 (more config) bot is broken..

Not sure why this CL wasn't closed. I closed it now.

Powered by Google App Engine
This is Rietveld 408576698