Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: webrtc/media/BUILD.gn

Issue 2945233002: Try to fix the binary size increase issue on Chromium. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/common_video/BUILD.gn ('k') | webrtc/pc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/BUILD.gn
diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn
index 249ceb89ffebf1a2ae4021dd9356d64bb064ec9d..ec00b049b696db4c62ac04785fb89d715fca74df 100644
--- a/webrtc/media/BUILD.gn
+++ b/webrtc/media/BUILD.gn
@@ -32,6 +32,24 @@ config("rtc_media_warnings_config") {
}
}
+rtc_source_set("rtc_h264_profile_id") {
+ sources = [
+ "base/h264_profile_level_id.cc",
+ "base/h264_profile_level_id.h",
+ ]
+
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+
+ deps = [
+ "..:webrtc_common",
+ "../base:rtc_base",
+ "../base:rtc_base_approved",
+ ]
+}
+
rtc_source_set("rtc_media_base") {
# TODO(kjellander): Remove (bugs.webrtc.org/6828)
# Enabling GN check triggers cyclic dependency error:
@@ -51,8 +69,6 @@ rtc_source_set("rtc_media_base") {
"base/codec.h",
"base/cryptoparams.h",
"base/device.h",
- "base/h264_profile_level_id.cc",
- "base/h264_profile_level_id.h",
"base/mediachannel.h",
"base/mediaconstants.cc",
"base/mediaconstants.h",
@@ -96,6 +112,7 @@ rtc_source_set("rtc_media_base") {
}
deps += [
+ ":rtc_h264_profile_id",
"..:webrtc_common",
"../api:libjingle_peerconnection_api",
"../base:rtc_base",
« no previous file with comments | « webrtc/common_video/BUILD.gn ('k') | webrtc/pc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698