Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2946893002: Hotfix for psnr regresion with fec tests caused by timing frames. (Closed)

Created:
3 years, 6 months ago by ilnik
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), kwiberg-webrtc, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Hotfix for psnr regresion with fec tests caused by timing frames. BUG=chromium:735001, webrtc:7594 Review-Url: https://codereview.webrtc.org/2946893002 Cr-Commit-Position: refs/heads/master@{#18681} Committed: https://chromium.googlesource.com/external/webrtc/+/2b3e06144399ef070a99932ccb9e0f267c233ec7

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : fix typos #

Patch Set 4 : Disable obsolete test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
ilnik
Extra fast hotfix for perf regression due to broken FEC. Please review ASAP.
3 years, 6 months ago (2017-06-20 13:56:10 UTC) #2
åsapersson
lgtm https://codereview.webrtc.org/2946893002/diff/20001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/2946893002/diff/20001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode747 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:747: // video timing extension because only some packets ...
3 years, 6 months ago (2017-06-20 14:09:48 UTC) #3
ilnik
https://codereview.webrtc.org/2946893002/diff/20001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/2946893002/diff/20001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode747 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:747: // video timing extension because only some packets have ...
3 years, 6 months ago (2017-06-20 14:13:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893002/40001
3 years, 6 months ago (2017-06-20 14:14:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893002/40001
3 years, 6 months ago (2017-06-20 14:16:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/13743)
3 years, 6 months ago (2017-06-20 14:29:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2946893002/60001
3 years, 6 months ago (2017-06-20 15:19:52 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 15:52:33 UTC) #20
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/2b3e06144399ef070a99932cc...

Powered by Google App Engine
This is Rietveld 408576698