Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

Issue 2946893002: Hotfix for psnr regresion with fec tests caused by timing frames. (Closed)
Patch Set: Disable obsolete test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 fake_clock_.TimeInMilliseconds(), false, 456 fake_clock_.TimeInMilliseconds(), false,
457 PacedPacketInfo()); 457 PacedPacketInfo());
458 458
459 const auto& packet = transport_.last_sent_packet(); 459 const auto& packet = transport_.last_sent_packet();
460 uint16_t transport_seq_no; 460 uint16_t transport_seq_no;
461 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no)); 461 EXPECT_TRUE(packet.GetExtension<TransportSequenceNumber>(&transport_seq_no));
462 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no); 462 EXPECT_EQ(kTransportSequenceNumber, transport_seq_no);
463 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no); 463 EXPECT_EQ(transport_.last_packet_id_, transport_seq_no);
464 } 464 }
465 465
466 TEST_P(RtpSenderTestWithoutPacer, WritesTimestampToTimingExtension) { 466 // Disabled due to webrtc:7859. Until issues with FEC resolved, pacer exit
467 // timstamp is not updated in the pacer.
468 TEST_P(RtpSenderTestWithoutPacer, DISABLED_WritesTimestampToTimingExtension) {
467 rtp_sender_->SetStorePacketsStatus(true, 10); 469 rtp_sender_->SetStorePacketsStatus(true, 10);
468 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension( 470 EXPECT_EQ(0, rtp_sender_->RegisterRtpHeaderExtension(
469 kRtpExtensionVideoTiming, kVideoTimingExtensionId)); 471 kRtpExtensionVideoTiming, kVideoTimingExtensionId));
470 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds(); 472 int64_t capture_time_ms = fake_clock_.TimeInMilliseconds();
471 auto packet = rtp_sender_->AllocatePacket(); 473 auto packet = rtp_sender_->AllocatePacket();
472 packet->SetPayloadType(kPayload); 474 packet->SetPayloadType(kPayload);
473 packet->SetMarker(true); 475 packet->SetMarker(true);
474 packet->SetTimestamp(kTimestamp); 476 packet->SetTimestamp(kTimestamp);
475 packet->set_capture_time_ms(capture_time_ms); 477 packet->set_capture_time_ms(capture_time_ms);
476 const VideoTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true}; 478 const VideoTiming kVideoTiming = {0u, 0u, 0u, 0u, 0u, 0u, true};
(...skipping 1139 matching lines...) Expand 10 before | Expand all | Expand 10 after
1616 INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, 1618 INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1617 RtpSenderTestWithoutPacer, 1619 RtpSenderTestWithoutPacer,
1618 ::testing::Bool()); 1620 ::testing::Bool());
1619 INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, 1621 INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1620 RtpSenderVideoTest, 1622 RtpSenderVideoTest,
1621 ::testing::Bool()); 1623 ::testing::Bool());
1622 INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead, 1624 INSTANTIATE_TEST_CASE_P(WithAndWithoutOverhead,
1623 RtpSenderAudioTest, 1625 RtpSenderAudioTest,
1624 ::testing::Bool()); 1626 ::testing::Bool());
1625 } // namespace webrtc 1627 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698