Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2939903002: Revert of Roll chromium_revision 05ba7bc226..78764cfda4 (479231:479277) (Closed)

Created:
3 years, 6 months ago by mbonadei
Modified:
3 years, 6 months ago
Reviewers:
buildbot
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll chromium_revision 05ba7bc226..78764cfda4 (479231:479277) (patchset #1 id:1 of https://codereview.webrtc.org/2936153002/ ) Reason for revert: Do not spam devs with confusing errors. This is caused by a chromium change that affects our android perf bots. Original issue's description: > Roll chromium_revision 05ba7bc226..78764cfda4 (479231:479277) > > Change log: https://chromium.googlesource.com/chromium/src/+log/05ba7bc226..78764cfda4 > Full diff: https://chromium.googlesource.com/chromium/src/+/05ba7bc226..78764cfda4 > > Changed dependencies: > * src/build: https://chromium.googlesource.com/chromium/src/build/+log/4280b28b9a..6aeb18a7f5 > * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/0dceaea435..a3fcf113d1 > * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/02c59642df..bb1a23cc9a > * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/github.com/google/gtest-parallel/+log/886cbd9635..6fb62e80ac > * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/d27b3e5170..0c5cd7a92e > DEPS diff: https://chromium.googlesource.com/chromium/src/+/05ba7bc226..78764cfda4/DEPS > > No update to Clang. > > TBR= > BUG=None > > Review-Url: https://codereview.webrtc.org/2936153002 > Cr-Commit-Position: refs/heads/master@{#18581} > Committed: https://chromium.googlesource.com/external/webrtc/+/b7d601552971992d40e84a70f936ea4e38044d91 TBR=buildbot@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:733108 Review-Url: https://codereview.webrtc.org/2939903002 Cr-Commit-Position: refs/heads/master@{#18584} Committed: https://chromium.googlesource.com/external/webrtc/+/58c5a7d4acd321d41baa3076dc6d5c1655b0ccbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mbonadei
Created Revert of Roll chromium_revision 05ba7bc226..78764cfda4 (479231:479277)
3 years, 6 months ago (2017-06-14 06:31:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2939903002/1
3 years, 6 months ago (2017-06-14 06:32:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/58c5a7d4acd321d41baa3076dc6d5c1655b0ccbd
3 years, 6 months ago (2017-06-14 06:32:54 UTC) #7
mbonadei
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2942593002/ by mbonadei@webrtc.org. ...
3 years, 6 months ago (2017-06-14 12:24:51 UTC) #8
kjellander_webrtc
3 years, 6 months ago (2017-06-14 18:06:34 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2936243002/ by kjellander@webrtc.org.

The reason for reverting is: The failing perf test is likely fixed in
https://codereview.webrtc.org/2935263002.

Powered by Google App Engine
This is Rietveld 408576698