Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2935263002: Also scan stderr for audio files to test, due to change in Android test_runner (Closed)

Created:
3 years, 6 months ago by oprypin_webrtc
Modified:
3 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Also scan stderr for audio files to test, due to change in Android test_runner BUG=chromium:733108 NOTRY=True Review-Url: https://codereview.webrtc.org/2935263002 Cr-Commit-Position: refs/heads/master@{#18595} Committed: https://chromium.googlesource.com/external/webrtc/+/4f1f458a1472d693d32c76290b835c53443df63c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/audio/test/low_bandwidth_audio_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
oprypin_webrtc
This is a workaround but may be a good idea to land to unblock rolls. ...
3 years, 6 months ago (2017-06-14 14:14:10 UTC) #3
kjellander_webrtc
lgtm and added NOTRY=True for you. Why is this a workaround? It seems like it's ...
3 years, 6 months ago (2017-06-14 14:52:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2935263002/1
3 years, 6 months ago (2017-06-14 16:33:00 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 16:35:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4f1f458a1472d693d32c76290...

Powered by Google App Engine
This is Rietveld 408576698