Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2938013003: Delete SignalSrtpError. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete SignalSrtpError. This became unused with cl https://codereview.webrtc.org/1362913004. BUG=webrtc:4690, webrtc:6424 Review-Url: https://codereview.webrtc.org/2938013003 Cr-Commit-Position: refs/heads/master@{#18623} Committed: https://chromium.googlesource.com/external/webrtc/+/af99b6d67af95615c8fc2f6dbea20983dd14385d

Patch Set 1 #

Patch Set 2 : Delete left-over declaration of set_signal_silent_time. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -566 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/base/sigslotrepeater.h View 1 chunk +0 lines, -94 lines 1 comment Download
M webrtc/media/base/mediaengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/channel_unittest.cc View 5 chunks +0 lines, -104 lines 0 comments Download
M webrtc/pc/srtpfilter.h View 1 7 chunks +0 lines, -87 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 10 chunks +1 line, -110 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 1 chunk +0 lines, -169 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nisse-webrtc
Can we delete this now? 20 months ago, Peter said you wanted it around because ...
3 years, 6 months ago (2017-06-15 08:39:48 UTC) #2
pthatcher1
lgtm
3 years, 6 months ago (2017-06-16 01:55:51 UTC) #3
the sun
lgtm
3 years, 6 months ago (2017-06-16 07:23:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2938013003/20001
3 years, 6 months ago (2017-06-16 07:34:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/af99b6d67af95615c8fc2f6dbea20983dd14385d
3 years, 6 months ago (2017-06-16 07:57:27 UTC) #9
Taylor Brandstetter
3 years, 2 months ago (2017-09-27 22:22:02 UTC) #11
Message was sent while issue was closed.
https://codereview.webrtc.org/2938013003/diff/20001/webrtc/base/sigslotrepeat...
File webrtc/base/sigslotrepeater.h (left):

https://codereview.webrtc.org/2938013003/diff/20001/webrtc/base/sigslotrepeat...
webrtc/base/sigslotrepeater.h:23: namespace sigslot {
I wanted to use this... It would actually simplify a lot of our code; I have no
idea why we don't use it already. I think I'll add it back using a variadic
template.

Powered by Google App Engine
This is Rietveld 408576698