Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1362913004: Remove unused SignalMediaError and infrastructure. (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused SignalMediaError and infrastructure. BUG=webrtc:4690 Committed: https://crrev.com/5b14b42e93f17d0ea57f1f8b3e8224082c514946 Cr-Commit-Position: refs/heads/master@{#10133}

Patch Set 1 #

Patch Set 2 : more #

Total comments: 1

Patch Set 3 : rebase+better tests #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -296 lines) Patch
M talk/media/base/fakemediaengine.h View 1 2 3 4 4 chunks +0 lines, -16 lines 0 comments Download
M talk/media/base/mediachannel.h View 1 2 3 4 3 chunks +0 lines, -17 lines 0 comments Download
M talk/media/base/videoengine_unittest.h View 1 2 3 4 2 chunks +0 lines, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 2 chunks +0 lines, -74 lines 0 comments Download
M talk/session/media/channel.h View 1 2 3 4 9 chunks +2 lines, -21 lines 0 comments Download
M talk/session/media/channel.cc View 1 2 3 4 11 chunks +1 line, -111 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 1 2 3 4 8 chunks +27 lines, -39 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
the sun
Nobody is hooked up to listen to [Voice|Video|Data]Channel::SignalMediaError, so they can be safely removed. A ...
5 years, 2 months ago (2015-09-25 11:16:37 UTC) #2
pthatcher1
I think we should leave the SignalSrtpError for now. We might actually want that around ...
5 years, 2 months ago (2015-09-25 17:18:52 UTC) #3
the sun
On 2015/09/25 17:18:52, pthatcher1 wrote: > I think we should leave the SignalSrtpError for now. ...
5 years, 2 months ago (2015-09-28 10:34:23 UTC) #4
the sun
5 years, 2 months ago (2015-09-28 10:34:30 UTC) #5
pthatcher1
lgtm
5 years, 2 months ago (2015-09-30 22:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362913004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362913004/60001
5 years, 2 months ago (2015-10-01 08:58:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/8442)
5 years, 2 months ago (2015-10-01 09:01:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1362913004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1362913004/80001
5 years, 2 months ago (2015-10-01 09:34:55 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-01 11:10:36 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 11:10:48 UTC) #16
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5b14b42e93f17d0ea57f1f8b3e8224082c514946
Cr-Commit-Position: refs/heads/master@{#10133}

Powered by Google App Engine
This is Rietveld 408576698