Validate references of frames inserted into FrameBuffer2.

Validate references of frames inserted into FrameBuffer2.

BUG=chromium:730603
Review-Url: https://codereview.webrtc.org/2937243002
Cr-Commit-Position: refs/heads/master@{#18614}
Committed: https://chromium.googlesource.com/external/webrtc/+/112adf9ca9e2ea3bc251345fbac46e1d22ed0a57

[philipel, 2017-06-15 15:38:40]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org, tommi@webrtc.org

[philipel, 2017-06-15 15:38:43]

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_buffer2.cc (left):

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.cc:273: if
(frame->inter_layer_predicted && frame->spatial_layer == 0) {
This check moved to line 251.

[tommi, 2017-06-15 15:42:12]

lgtm

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_buffer2.h (right):

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.h:100: // TODO(philipel): Add simple
modify/access functions to prevent adding to
nit: adding too

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_object.h (right):

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_object.h:54: // TODO(philipel): Add simple
modify/access functions to prevent adding to
nit: adding too

[stefan-webrtc, 2017-06-15 15:47:09]

lgtm

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/frame_buffer2.h (right):

https://codereview.webrtc.org/2937243002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/frame_buffer2.h:100: // TODO(philipel): Add simple
modify/access functions to prevent adding to
too

[philipel, 2017-06-15 15:47:39]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2017-06-15 15:47:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2937243002/#ps40001 (title:
"to --> too")

[commit-bot: I haz the power, 2017-06-15 15:47:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-15 16:06:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497541659937880,
"parent_rev": "eb02c03a53734b6faf01d7f98a6174918169b850", "commit_rev":
"112adf9ca9e2ea3bc251345fbac46e1d22ed0a57"}

[commit-bot: I haz the power, 2017-06-15 16:06:27]

Description was changed from

==========
Validate references of frames inserted into FrameBuffer2.

BUG=chromium:730603
==========

to

==========
Validate references of frames inserted into FrameBuffer2.

BUG=chromium:730603

Review-Url: https://codereview.webrtc.org/2937243002
Cr-Commit-Position: refs/heads/master@{#18614}
Committed:
https://chromium.googlesource.com/external/webrtc/+/112adf9ca9e2ea3bc251345fb...
==========

[commit-bot: I haz the power, 2017-06-15 16:06:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/112adf9ca9e2ea3bc251345fb...