Validate references of frames inserted into FrameBuffer2.

webrtc/modules/video_coding/frame_buffer2.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 79 matching lines @@
     uint16_t picture_id;
     uint8_t spatial_layer;
   };
 
   struct FrameInfo {
     // The maximum number of frames that can depend on this frame.
     static constexpr size_t kMaxNumDependentFrames = 8;
 
     // Which other frames that have direct unfulfilled dependencies
     // on this frame.
+    // TODO(philipel): Add simple modify/access functions to prevent adding to

[tommi, 2017/06/15 15:42:10]

nit: adding too

[stefan-webrtc, 2017/06/15 15:47:09]

too

+    // many |dependent_frames|.
     FrameKey dependent_frames[kMaxNumDependentFrames];
     size_t num_dependent_frames = 0;
 
     // A frame is continiuous if it has all its referenced/indirectly
     // referenced frames.
     //
     // How many unfulfilled frames this frame have until it becomes continuous.
     size_t num_missing_continuous = 0;
 
     // A frame is decodable if all its referenced frames have been decoded.
     //
     // How many unfulfilled frames this frame have until it becomes decodable.
     size_t num_missing_decodable = 0;
 
     // If this frame is continuous or not.
     bool continuous = false;
 
     // The actual FrameObject.
     std::unique_ptr<FrameObject> frame;
   };
 
   using FrameMap = std::map<FrameKey, FrameInfo>;
 
+  // Check that the references of |frame| are valid.
+  bool ValidReferences(const FrameObject& frame) const;
+
   // Updates the minimal and maximal playout delays
   // depending on the frame.
   void UpdatePlayoutDelays(const FrameObject& frame)
       EXCLUSIVE_LOCKS_REQUIRED(crit_);
 
   // Update all directly dependent and indirectly dependent frames and mark
   // them as continuous if all their references has been fulfilled.
   void PropagateContinuity(FrameMap::iterator start)
       EXCLUSIVE_LOCKS_REQUIRED(crit_);
 
@@ skipping 38 matching lines @@
   VCMVideoProtection protection_mode_ GUARDED_BY(crit_);
   VCMReceiveStatisticsCallback* const stats_callback_;
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FrameBuffer);
 };
 
 }  // namespace video_coding
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_CODING_FRAME_BUFFER2_H_