Fix play block size mismatch in Win audio device.

Fix play block size mismatch in Win audio device.

All of the buffer size returned by Windows Core Audio APIs are in unit
of audio frames (which is sample times number of channels), while
WebRTC's AudioDeviceBuffer RequestPlayoutData method takes in samples
per channel (equivalent to frames per channel) but returns number of
audio samples in all the channels. This CL makes sure that we compare
playout block size in frames with frames and size in samples with
samples, which should fix the excessive logging issues and audio quality
problems due to the mismatch when comparing.

BUG=webrtc:7797
Review-Url: https://codereview.webrtc.org/2933953003
Cr-Commit-Position: refs/heads/master@{#18546}
Committed: https://chromium.googlesource.com/external/webrtc/+/c35c7dedc09fac7bc7aabe8ec4fabf00e8060b8e

[lliuu, 2017-06-12 23:11:58]

The CQ bit was checked by lliuu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 23:12:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[lliuu, 2017-06-12 23:20:01]

The CQ bit was checked by lliuu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 23:20:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[lliuu, 2017-06-12 23:20:31]

Description was changed from

==========
Fix play block size mismatch in Win audio device.

All of the buffer size returned by Windows Core Audio APIs are in unit
of audio frames (which is sample times number of channels), while
WebRTC's AudioDeviceBuffer RequestPlayoutData method takes in samples
per channel (equivalent to frames per channel) but returns number of
audio samples in all the channels. This CL makes sure that we compare
playout block size in frames with frames and size in samples with
samples, which should fix the excessive logging issues and audio quality
problems due to the mismatch when comparing.

BUG=webrtc:7797
==========

to

==========
Fix play block size mismatch in Win audio device.

All of the buffer size returned by Windows Core Audio APIs are in unit
of audio frames (which is sample times number of channels), while
WebRTC's AudioDeviceBuffer RequestPlayoutData method takes in samples
per channel (equivalent to frames per channel) but returns number of
audio samples in all the channels. This CL makes sure that we compare
playout block size in frames with frames and size in samples with
samples, which should fix the excessive logging issues and audio quality
problems due to the mismatch when comparing.

BUG=webrtc:7797
==========

[lliuu, 2017-06-12 23:20:31]

lliuu@webrtc.org changed reviewers:
+ henrika@webrtc.org, niklas.enbom@webrtc.org

[lliuu, 2017-06-12 23:22:08]

On 2017/06/12 23:20:31, lliuu wrote:
> mailto:lliuu@webrtc.org changed reviewers:
> + mailto:henrika@webrtc.org, mailto:niklas.enbom@webrtc.org

Most of the diff in the cc file came from running git cl format, let me know if
you want to have the format diffs reverted

[niklas.enbom, 2017-06-12 23:31:14]

lgtm, I should have caught this in the prev review...

On 2017/06/12 23:22:08, lliuu wrote:
> On 2017/06/12 23:20:31, lliuu wrote:
> > mailto:lliuu@webrtc.org changed reviewers:
> > + mailto:henrika@webrtc.org, mailto:niklas.enbom@webrtc.org
> 
> Most of the diff in the cc file came from running git cl format, let me know
if
> you want to have the format diffs reverted

[commit-bot: I haz the power, 2017-06-12 23:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 23:43:57]

Dry run: This issue passed the CQ dry run.

[lliuu, 2017-06-12 23:51:55]

The CQ bit was checked by lliuu@webrtc.org

[commit-bot: I haz the power, 2017-06-12 23:52:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-12 23:54:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497311515813840,
"parent_rev": "84da736e92ce488b4c5417a10643e53aa080e494", "commit_rev":
"c35c7dedc09fac7bc7aabe8ec4fabf00e8060b8e"}

[commit-bot: I haz the power, 2017-06-12 23:54:11]

Description was changed from

==========
Fix play block size mismatch in Win audio device.

All of the buffer size returned by Windows Core Audio APIs are in unit
of audio frames (which is sample times number of channels), while
WebRTC's AudioDeviceBuffer RequestPlayoutData method takes in samples
per channel (equivalent to frames per channel) but returns number of
audio samples in all the channels. This CL makes sure that we compare
playout block size in frames with frames and size in samples with
samples, which should fix the excessive logging issues and audio quality
problems due to the mismatch when comparing.

BUG=webrtc:7797
==========

to

==========
Fix play block size mismatch in Win audio device.

All of the buffer size returned by Windows Core Audio APIs are in unit
of audio frames (which is sample times number of channels), while
WebRTC's AudioDeviceBuffer RequestPlayoutData method takes in samples
per channel (equivalent to frames per channel) but returns number of
audio samples in all the channels. This CL makes sure that we compare
playout block size in frames with frames and size in samples with
samples, which should fix the excessive logging issues and audio quality
problems due to the mismatch when comparing.

BUG=webrtc:7797

Review-Url: https://codereview.webrtc.org/2933953003
Cr-Commit-Position: refs/heads/master@{#18546}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c35c7dedc09fac7bc7aabe8ec...
==========

[commit-bot: I haz the power, 2017-06-12 23:54:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c35c7dedc09fac7bc7aabe8ec...

[henrika_webrtc, 2017-06-13 12:11:38]

Thanks for fixing. I missed it as well. Sorry if the existing interface is not
perfect.

lgtm