Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2897423002: Revert of https://codereview.webrtc.org/2889183002/ (Closed)

Created:
3 years, 7 months ago by lliuu
Modified:
3 years, 7 months ago
Reviewers:
niklas.enbom
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of https://codereview.webrtc.org/2889183002/ And also revert https://codereview.webrtc.org/2888093005/ (Chromium roll) which has a dependency on 2889183002 BUG=webrtc:7707 Review-Url: https://codereview.webrtc.org/2897423002 Cr-Commit-Position: refs/heads/master@{#18263} Committed: https://chromium.googlesource.com/external/webrtc/+/548cdce7bc34101df8313ef4b55d1b28a4014a05

Patch Set 1 #

Patch Set 2 : new #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -202 lines) Patch
M DEPS View 1 11 chunks +13 lines, -24 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/ensure_initialized.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 5 chunks +7 lines, -10 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/utility/include/jvm_android.h View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/utility/source/jvm_android.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M webrtc/pc/test/androidtestinitializer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/PeerConnectionFactory.java View 3 chunks +3 lines, -10 lines 0 comments Download
M webrtc/sdk/android/src/jni/peerconnection_jni.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D webrtc/test/android/AndroidManifest.xml View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/test/android/org/webrtc/native_test/RTCNativeUnitTest.java View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/test/android/org/webrtc/native_test/RTCNativeUnitTestActivity.java View 1 chunk +0 lines, -34 lines 0 comments Download
M webrtc/webrtc.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
lliuu
Niklas, please review
3 years, 7 months ago (2017-05-24 23:34:51 UTC) #11
niklas.enbom
lgtm On 2017/05/24 23:34:51, lliuu wrote: > Niklas, please review
3 years, 7 months ago (2017-05-24 23:35:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2897423002/20001
3 years, 7 months ago (2017-05-24 23:38:33 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 23:46:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/548cdce7bc34101df8313ef4b...

Powered by Google App Engine
This is Rietveld 408576698