Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2930023002: Delete unused method FilesystemInterface::DeleteEmptyFolder. (Closed)

Created:
3 years, 6 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused method FilesystemInterface::DeleteEmptyFolder. It's left-over since cl https://codereview.webrtc.org/2887093002. In addition, fix override declarations and formatting in win32filesystem.h. BUG=webrtc:7345, webrtc:6424 Review-Url: https://codereview.webrtc.org/2930023002 Cr-Commit-Position: refs/heads/master@{#18549} Committed: https://chromium.googlesource.com/external/webrtc/+/f52ef71db7cad23327077fe9e6ae996802cee838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -48 lines) Patch
M webrtc/base/fileutils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/base/unixfilesystem.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/base/win32filesystem.h View 1 chunk +18 lines, -19 lines 0 comments Download
M webrtc/base/win32filesystem.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-webrtc
PTAL
3 years, 6 months ago (2017-06-09 11:35:15 UTC) #2
Taylor Brandstetter
lgtm
3 years, 6 months ago (2017-06-09 21:14:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2930023002/1
3 years, 6 months ago (2017-06-13 06:46:37 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 07:10:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f52ef71db7cad23327077fe9e...

Powered by Google App Engine
This is Rietveld 408576698