Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 2887093002: Delete FilesystemInterface::DeleteFolderAndContents and related methods. (Closed)

Created:
3 years, 7 months ago by nisse-webrtc
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete FilesystemInterface::DeleteFolderAndContents and related methods. Additional methods deleted: DeleteFolderContents IsTemporaryPath GetAppTempFolder Unused since cl https://codereview.webrtc.org/2872283002/ BUG=webrtc:7345, webrtc:6424 Review-Url: https://codereview.webrtc.org/2887093002 Cr-Commit-Position: refs/heads/master@{#18194} Committed: https://chromium.googlesource.com/external/webrtc/+/b243ee91c3b1e7cfc27f28d8ac17a7a8a9943cca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -150 lines) Patch
M webrtc/base/fileutils.h View 6 chunks +0 lines, -34 lines 0 comments Download
M webrtc/base/fileutils.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/base/unixfilesystem.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/base/unixfilesystem.cc View 2 chunks +0 lines, -53 lines 0 comments Download
M webrtc/base/win32filesystem.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/base/win32filesystem.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nisse-webrtc
This method now unused in webrtc.
3 years, 7 months ago (2017-05-17 11:40:08 UTC) #2
pthatcher1
lgtm
3 years, 7 months ago (2017-05-17 16:53:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2887093002/1
3 years, 7 months ago (2017-05-18 12:47:47 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 12:50:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b243ee91c3b1e7cfc27f28d8a...

Powered by Google App Engine
This is Rietveld 408576698