Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(63)

Issue 2926893002: arc: Start ARC for Public Session users.

Created:
2 years, 1 month ago by Sergey Poromov
Modified:
1 year, 9 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Start ARC for Public Session users. If 'ArcEnabled' policy is set to 'true' for public session account, then ARC container will be started. 'ArcBackupRestoreEnabled' and 'ArcLocationServiceEnabled' policies should also be defined to start ARC silently without any user interaction (skipping ToS). Android authentication flow is the same as for ARC Kiosk accounts, robot account is reused. As side effect of this change, ephemeral mode block is removed and ARC could be started in ephemeral mode for regular user session. TEST=Set policies, start public session. BUG=731097

Patch Set 1 #

Patch Set 2 : Update unit tests. #

Total comments: 11

Patch Set 3 : Fix missed IsPublicSessionMode() checks. #

Patch Set 4 : Fix missed IsPublicSessionMode() checks. #

Total comments: 4

Patch Set 5 : Combine IsArcKioskMode() and IsPublicSessionMode() into IsRobotAccountMode(). #

Total comments: 4

Patch Set 6 : Remove IsPublicSessionMode() #

Patch Set 7 : Hide Play Store #

Patch Set 8 : Hide Play Store #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -36 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager.cc View 1 2 3 4 5 6 6 chunks +21 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_util_unittest.cc View 1 2 3 4 5 6 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/auth/arc_auth_service.cc View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M components/arc/arc_util.h View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M components/arc/arc_util.cc View 1 2 3 4 5 6 7 3 chunks +14 lines, -11 lines 1 comment Download
M components/arc/arc_util_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 42 (24 generated)
poromov
2 years, 1 month ago (2017-06-07 17:35:33 UTC) #2
hidehiko
Could you add concrete BUG= line? Also, could you share a (even shorter) design doc, ...
2 years, 1 month ago (2017-06-08 12:02:27 UTC) #9
Sergey Poromov
On 2017/06/08 12:02:27, hidehiko wrote: > Could you add concrete BUG= line? > Also, could ...
2 years, 1 month ago (2017-06-08 13:56:10 UTC) #11
Sergey Poromov
https://codereview.chromium.org/2926893002/diff/20001/chrome/browser/chromeos/arc/arc_session_manager.cc File chrome/browser/chromeos/arc/arc_session_manager.cc (right): https://codereview.chromium.org/2926893002/diff/20001/chrome/browser/chromeos/arc/arc_session_manager.cc#newcode263 chrome/browser/chromeos/arc/arc_session_manager.cc:263: if (IsArcKioskMode()) { On 2017/06/08 12:02:27, hidehiko wrote: > ...
2 years, 1 month ago (2017-06-08 13:56:19 UTC) #12
Sergey Poromov
2 years, 1 month ago (2017-06-08 13:56:48 UTC) #16
Sergey Poromov
Hey all, please review this CL. It's recalled again as required ChromeOS ephemeral filesystem CL ...
1 year, 10 months ago (2017-08-28 18:24:13 UTC) #22
Luis Héctor Chávez
https://codereview.chromium.org/2926893002/diff/60001/chrome/browser/chromeos/arc/arc_session_manager.cc File chrome/browser/chromeos/arc/arc_session_manager.cc (right): https://codereview.chromium.org/2926893002/diff/60001/chrome/browser/chromeos/arc/arc_session_manager.cc#newcode746 chrome/browser/chromeos/arc/arc_session_manager.cc:746: // In Kiosk and PublicSession-mode, Terms of Service negotiation ...
1 year, 10 months ago (2017-08-28 18:33:29 UTC) #24
Sergey Poromov
https://codereview.chromium.org/2926893002/diff/60001/chrome/browser/chromeos/arc/arc_session_manager.cc File chrome/browser/chromeos/arc/arc_session_manager.cc (right): https://codereview.chromium.org/2926893002/diff/60001/chrome/browser/chromeos/arc/arc_session_manager.cc#newcode746 chrome/browser/chromeos/arc/arc_session_manager.cc:746: // In Kiosk and PublicSession-mode, Terms of Service negotiation ...
1 year, 10 months ago (2017-08-28 18:47:25 UTC) #27
Luis Héctor Chávez
https://codereview.chromium.org/2926893002/diff/80001/components/arc/arc_util.h File components/arc/arc_util.h (right): https://codereview.chromium.org/2926893002/diff/80001/components/arc/arc_util.h#newcode79 components/arc/arc_util.h:79: bool IsArcKioskMode(); This _should_ now be unused. Can you ...
1 year, 10 months ago (2017-08-29 16:24:09 UTC) #28
Sergey Poromov
https://codereview.chromium.org/2926893002/diff/80001/components/arc/arc_util.h File components/arc/arc_util.h (right): https://codereview.chromium.org/2926893002/diff/80001/components/arc/arc_util.h#newcode79 components/arc/arc_util.h:79: bool IsArcKioskMode(); On 2017/08/29 16:24:09, Luis Héctor Chávez wrote: ...
1 year, 10 months ago (2017-08-29 16:37:31 UTC) #29
Sergey Poromov
Friendly ping.
1 year, 10 months ago (2017-08-30 16:15:54 UTC) #30
khmel
Sorry for delay. This CL looks incomplete. From bug desc: Access to the Play Store ...
1 year, 10 months ago (2017-08-30 16:22:20 UTC) #31
khmel
Sorry for delay. This CL looks incomplete. From bug desc: Access to the Play Store ...
1 year, 10 months ago (2017-08-30 16:22:21 UTC) #32
Sergey Poromov
On 2017/08/30 16:22:21, khmel wrote: > Sorry for delay. > > This CL looks incomplete. ...
1 year, 10 months ago (2017-08-30 16:48:44 UTC) #33
khmel
On 2017/08/30 16:48:44, Sergey Poromov wrote: > On 2017/08/30 16:22:21, khmel wrote: > > Sorry ...
1 year, 10 months ago (2017-08-30 16:56:36 UTC) #34
Sergey Poromov
On 2017/08/30 16:56:36, khmel wrote: > On 2017/08/30 16:48:44, Sergey Poromov wrote: > > On ...
1 year, 9 months ago (2017-09-25 19:47:52 UTC) #37
khmel
lgtm https://codereview.chromium.org/2926893002/diff/140001/components/arc/arc_util.cc File components/arc/arc_util.cc (right): https://codereview.chromium.org/2926893002/diff/140001/components/arc/arc_util.cc#newcode88 components/arc/arc_util.cc:88: !IsRobotAccountMode()) { nit: I would prefer if (IsRobotAccountMode()) ...
1 year, 9 months ago (2017-09-26 17:58:26 UTC) #40
hidehiko1
1 year, 9 months ago (2017-09-27 07:27:21 UTC) #42
LGTM with Yury's comment.

Clarification:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/arc_util.cc?...

There is no "ARC is allowed only for public-session devices", unlike ARC Kiosk.

Powered by Google App Engine
This is Rietveld 408576698