arc: Start ARC for Public Session users.

components/arc/arc_util.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_util.h"
 
 #include <string>
 
 #include "ash/public/cpp/app_types.h"
 #include "base/command_line.h"
@@ skipping 66 matching lines @@
     const std::string value =
         command_line->GetSwitchValueASCII(chromeos::switches::kArcAvailability);
 
     return value == kAvailabilityNone;
   }
   return true;
 }
 
 bool IsPlayStoreAvailable() {
   const auto* command_line = base::CommandLine::ForCurrentProcess();
-  if (!command_line->HasSwitch(chromeos::switches::kArcStartMode))
+  if (!command_line->HasSwitch(chromeos::switches::kArcStartMode) &&
+      !IsRobotAccountMode()) {

[khmel, 2017/09/26 17:58:26]

nit: I would prefer 

if (IsRobotAccountMode())
  return false;

...

     return true;
+  }
 
   const std::string value =
       command_line->GetSwitchValueASCII(chromeos::switches::kArcStartMode);
-  return value != kAlwaysStartWithNoPlayStore;
+  return value != kAlwaysStartWithNoPlayStore && !IsRobotAccountMode();
 }
 
 bool ShouldArcAlwaysStart() {
   const auto* command_line = base::CommandLine::ForCurrentProcess();
   if (!command_line->HasSwitch(chromeos::switches::kArcStartMode))
     return false;
   const std::string value =
       command_line->GetSwitchValueASCII(chromeos::switches::kArcStartMode);
   return value == kAlwaysStartWithNoPlayStore || value == kAlwaysStart;
 }
@@ skipping 35 matching lines @@
 void SetArcAvailableCommandLineForTesting(base::CommandLine* command_line) {
   command_line->AppendSwitchASCII(chromeos::switches::kArcAvailability,
                                   kAvailabilityOfficiallySupported);
 }
 
 bool IsArcKioskMode() {
   return user_manager::UserManager::IsInitialized() &&
          user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp();
 }
 
+bool IsRobotAccountMode() {
+  return user_manager::UserManager::IsInitialized() &&
+         (user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp() ||
+          user_manager::UserManager::Get()->IsLoggedInAsPublicAccount());
+}
+
 bool IsArcAllowedForUser(const user_manager::User* user) {
   if (!user) {
     VLOG(1) << "No ARC for nullptr user.";
     return false;
   }
 
   // ARC is only supported for the following cases:
   // - Users have Gaia accounts;
   // - Active directory users;
   // - ARC kiosk session;
+  // - Public Session users;
   //   USER_TYPE_ARC_KIOSK_APP check is compatible with IsArcKioskMode()
   //   above because ARC kiosk user is always the primary/active user of a
-  //   user session.
+  //   user session. The same for USER_TYPE_PUBLIC_ACCOUNT.
   if (!user->HasGaiaAccount() && !user->IsActiveDirectoryUser() &&
-      user->GetType() != user_manager::USER_TYPE_ARC_KIOSK_APP) {
+      user->GetType() != user_manager::USER_TYPE_ARC_KIOSK_APP &&
+      user->GetType() != user_manager::USER_TYPE_PUBLIC_ACCOUNT) {
     VLOG(1) << "Users without GAIA or AD accounts, or not ARC kiosk apps are "
                "not supported in ARC.";
     return false;
   }
 
-  // Do not allow for ephemeral data user. cf) b/26402681
-  if (user_manager::UserManager::Get()->IsUserCryptohomeDataEphemeral(
-          user->GetAccountId())) {
-    VLOG(1) << "Users with ephemeral data are not supported in ARC.";
-    return false;
-  }
-
   return true;
 }
 
 bool IsArcOptInVerificationDisabled() {
   const auto* command_line = base::CommandLine::ForCurrentProcess();
   return command_line->HasSwitch(
       chromeos::switches::kDisableArcOptInVerification);
 }
 
 bool IsArcAppWindow(aura::Window* window) {
@@ skipping 11 matching lines @@
     return;
   }
   const login_manager::ContainerCpuRestrictionState state =
       do_restrict ? login_manager::CONTAINER_CPU_RESTRICTION_BACKGROUND
                   : login_manager::CONTAINER_CPU_RESTRICTION_FOREGROUND;
   session_manager_client->SetArcCpuRestriction(
       state, base::Bind(SetArcCpuRestrictionCallback, state));
 }
 
 }  // namespace arc