Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2924023002: Reland of Periodically update codec bit/frame rate settings. (Closed)

Created:
3 years, 6 months ago by sprang_webrtc
Modified:
3 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Periodically update codec bit/frame rate settings. (patchset #1 id:1 of https://codereview.webrtc.org/2923993002/ ) Reason for revert: Create reland cl that we can patch with fix. Original issue's description: > Revert of Periodically update codec bit/frame rate settings. (patchset #8 id:140001 of https://codereview.webrtc.org/2883963002/ ) > > Reason for revert: > Breaks some Call perf tests that are not run by the try bots.... > > Original issue's description: > > Fix bug in vie_encoder.cc which caused channel parameters not to be updated at regular intervals, as it was intended. > > > > That however exposes a bunch of failed test, so this CL also fixed a few other things: > > * FakeEncoder should trust the configured FPS value rather than guesstimating itself based on the realtime clock, so as not to completely undershoot targets in offline mode. Also, compensate for key-frame overshoots when outputting delta frames. > > * FrameDropper should not assuming incoming frame rate is 0 if no frames have been seen. > > * Fix a bunch of test cases that started failing because they were relying on the fake encoder undershooting. > > * Fix test > > > > BUG=7664 > > > > Review-Url: https://codereview.webrtc.org/2883963002 > > Cr-Commit-Position: refs/heads/master@{#18473} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6431e21da672a5f3bbf166d3d4d98b171d015706 > > TBR=stefan@webrtc.org,holmer@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=7664 > > Review-Url: https://codereview.webrtc.org/2923993002 > Cr-Commit-Position: refs/heads/master@{#18475} > Committed: https://chromium.googlesource.com/external/webrtc/+/5390c4814d7880ea79edcd55596ea25e0d9b97ad TBR=stefan@webrtc.org,holmer@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=7664 Review-Url: https://codereview.webrtc.org/2924023002 Cr-Commit-Position: refs/heads/master@{#18497} Committed: https://chromium.googlesource.com/external/webrtc/+/cdafeda1cb95ac49104b2cc5112bab8def863818

Patch Set 1 #

Patch Set 2 : Fix incorrect capping of target bitrate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -257 lines) Patch
M webrtc/media/engine/simulcast.cc View 1 4 chunks +35 lines, -65 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/test/fake_encoder.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/test/fake_encoder.cc View 1 7 chunks +48 lines, -36 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 chunks +34 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 6 chunks +2 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 92 chunks +235 lines, -145 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sprang_webrtc
Created Reland of Periodically update codec bit/frame rate settings.
3 years, 6 months ago (2017-06-07 14:23:59 UTC) #1
sprang_webrtc
stefan@, ptal at the delta from patch set 1 (only fake_encoder.cc has been changed)
3 years, 6 months ago (2017-06-07 14:30:32 UTC) #7
stefan-webrtc
lgtm
3 years, 6 months ago (2017-06-08 12:55:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2924023002/160001
3 years, 6 months ago (2017-06-08 13:12:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:160001) as https://chromium.googlesource.com/external/webrtc/+/cdafeda1cb95ac49104b2cc5112bab8def863818
3 years, 6 months ago (2017-06-08 13:12:11 UTC) #13
sprang_webrtc
3 years, 6 months ago (2017-06-08 14:12:02 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:160001) has been created in
https://codereview.webrtc.org/2926283002/ by sprang@webrtc.org.

The reason for reverting is: Looks like there's still one failing perf test:
RampUpTest.UpDownUpTransportSequenceNumberPacketLoss.

Powered by Google App Engine
This is Rietveld 408576698