Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2923993002: Revert of Periodically update codec bit/frame rate settings. (Closed)

Created:
3 years, 6 months ago by sprang_webrtc
Modified:
3 years, 6 months ago
Reviewers:
holmer, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Periodically update codec bit/frame rate settings. (patchset #8 id:140001 of https://codereview.webrtc.org/2883963002/ ) Reason for revert: Breaks some Call perf tests that are not run by the try bots.... Original issue's description: > Fix bug in vie_encoder.cc which caused channel parameters not to be updated at regular intervals, as it was intended. > > That however exposes a bunch of failed test, so this CL also fixed a few other things: > * FakeEncoder should trust the configured FPS value rather than guesstimating itself based on the realtime clock, so as not to completely undershoot targets in offline mode. Also, compensate for key-frame overshoots when outputting delta frames. > * FrameDropper should not assuming incoming frame rate is 0 if no frames have been seen. > * Fix a bunch of test cases that started failing because they were relying on the fake encoder undershooting. > * Fix test > > BUG=7664 > > Review-Url: https://codereview.webrtc.org/2883963002 > Cr-Commit-Position: refs/heads/master@{#18473} > Committed: https://chromium.googlesource.com/external/webrtc/+/6431e21da672a5f3bbf166d3d4d98b171d015706 TBR=stefan@webrtc.org,holmer@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=7664 Review-Url: https://codereview.webrtc.org/2923993002 Cr-Commit-Position: refs/heads/master@{#18475} Committed: https://chromium.googlesource.com/external/webrtc/+/5390c4814d7880ea79edcd55596ea25e0d9b97ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -385 lines) Patch
M webrtc/media/engine/simulcast.cc View 4 chunks +69 lines, -39 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.cc View 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/test/fake_encoder.h View 2 chunks +1 line, -7 lines 0 comments Download
M webrtc/test/fake_encoder.cc View 6 chunks +41 lines, -54 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 2 chunks +3 lines, -34 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 6 chunks +7 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 92 chunks +146 lines, -236 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sprang_webrtc
Created Revert of Periodically update codec bit/frame rate settings.
3 years, 6 months ago (2017-06-07 13:17:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2923993002/1
3 years, 6 months ago (2017-06-07 13:17:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/5390c4814d7880ea79edcd55596ea25e0d9b97ad
3 years, 6 months ago (2017-06-07 13:17:58 UTC) #6
sprang_webrtc
3 years, 6 months ago (2017-06-07 14:23:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2924023002/ by sprang@webrtc.org.

The reason for reverting is: Create reland cl that we can patch with fix..

Powered by Google App Engine
This is Rietveld 408576698