Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2920763002: Revert of Enabling `gn check` on webrtc/test (Closed)

Created:
3 years, 6 months ago by mbonadei
Modified:
3 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, AleBzk, kwiberg-webrtc, stefan-webrtc, henrika_webrtc, zhuangzesen_agora.io, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, minyue-webrtc, yujie_mao (webrtc), mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enabling `gn check` on webrtc/test (patchset #9 id:160001 of https://codereview.webrtc.org/2911203002/ ) Reason for revert: ERROR at //webrtc/test/testsupport/fileutils_unittest.cc:20:11: Can't include this header from here. #include "webrtc/base/checks.h" ^------------------- The target: //webrtc/test:fileutils_unittests is including a file from the target: //webrtc/base:rtc_base_approved It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //webrtc/test:fileutils_unittests --> //webrtc/test:fileutils --[private]--> //webrtc/base:rtc_base_approved Original issue's description: > Enabling `gn check` on webrtc/test > > BUG=webrtc:6828 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2911203002 > Cr-Commit-Position: refs/heads/master@{#18372} > Committed: https://chromium.googlesource.com/external/webrtc/+/db5bb404b0f42a7c0a43f882b34ba1325d8cbae2 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2920763002 Cr-Commit-Position: refs/heads/master@{#18375} Committed: https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -249 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 3 chunks +110 lines, -112 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 2 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 2 chunks +15 lines, -15 lines 0 comments Download
M webrtc/test/BUILD.gn View 12 chunks +4 lines, -56 lines 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 11 chunks +30 lines, -52 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mbonadei
Created Revert of Enabling `gn check` on webrtc/test
3 years, 6 months ago (2017-06-01 11:25:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2920763002/1
3 years, 6 months ago (2017-06-01 11:25:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/1a6f143d077aec85d919c516b4f74ada8b8c21a8
3 years, 6 months ago (2017-06-01 11:25:44 UTC) #6
mbonadei
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2918793002/ by mbonadei@webrtc.org. ...
3 years, 6 months ago (2017-06-01 11:28:37 UTC) #7
kjellander_webrtc
3 years, 6 months ago (2017-06-01 11:28:53 UTC) #8
Message was sent while issue was closed.
so close, but then a trybot race condition on turning this on hits us :P
lgtm

Powered by Google App Engine
This is Rietveld 408576698